Fix CI and clean warnings

Author: chaizhenhua

Cargo.lock

@@ -58,6 +58,7 @@ extra_features = ["worker", "snapshot_builder"]
 # (See [NodePermissions])
 node_experimental = [
     "deno_node", "deno_resolver", "node_resolver", "deno_npm", "deno_semver", "deno_napi", "deno_runtime", "deno_process", "deno_package_json",
+    "deno_bundle_runtime",
     "checksum", "sys_traits", "all_extensions"
 ]
 
@@ -118,7 +119,7 @@ web_stub = ["webidl", "base64-simd"]
     web = [
         "deno_web", "deno_tls", "deno_fetch", "deno_net", "dep:http", "deno_permissions", "deno_telemetry", "deno_fs",
         "webidl", "console", "url", "crypto", "url_import", "fs_import",
-        "hyper-util", "rustls"
+        "hyper-util", "rustls", "sys_traits"
     ]
 
     # [https://gpuweb.github.io/gpuweb/]
@@ -197,6 +198,7 @@ deno_permissions = { version = "^0.85.0", optional = true }
 
 deno_broadcast_channel = { version = "^0.216.0", optional = true }
 
+deno_bundle_runtime = { version = "^0.13.0", optional = true }
 deno_cache      = { version = "^0.159.0", optional = true }
 deno_console    = { version = "^0.222.0", optional = true }
 deno_cron       = { version = "^0.106.0", optional = true }
@@ -245,7 +247,7 @@ deno_npm      = { version = "^0.42.2", optional = true }
 deno_process  = { version = "^0.41.0", optional = true }
 deno_package_json = { version = "^0.28.0", optional = true }
 checksum      = { version = "0.2.1", optional = true }
-sys_traits    = { version = "=0.1.17", optional = true }
+sys_traits    = { version = "=0.1.17", optional = true, features = ["libc", "real", "winapi"] }
 
 [dev-dependencies]
 version-sync = "0.9.5"

Cargo.toml

@@ -78,7 +78,6 @@ impl ImportProvider for MyImportProvider {
         specifier: &ModuleSpecifier,
         _referrer: Option<&ModuleSpecifier>,
         _is_dyn_import: bool,
-        _requested_module_type: deno_core::RequestedModuleType,
     ) -> Option<Result<String, ModuleLoaderError>> {
         match specifier.scheme() {
             //
@@ -102,7 +101,10 @@ impl ImportProvider for MyImportProvider {
 
 fn main() -> Result<(), rustyscript::Error> {
     let mut import_provider = MyImportProvider::default();
-    import_provider.add_redirect("mod_assert", "https://deno.land/std@0.224.0/assert/mod.ts")?;
+    import_provider.add_redirect(
+        "mod_assert",
+        "https://deno.land/std@0.224.0/assert/assert.ts",
+    )?;
     import_provider.add_static_module("my-module", "export const foo = 1");
 
     let mut runtime = Runtime::new(RuntimeOptions {
@@ -113,10 +115,10 @@ fn main() -> Result<(), rustyscript::Error> {
     let module = Module::new(
         "custom_imports.js",
         "
-        import { assertEquals } from 'redirect:mod_assert';
+        import { assert } from 'redirect:mod_assert';
         import { foo } from 'static:my-module';
         
-        assertEquals(1, foo)
+        assert(foo === 1);
         ",
     );
 

examples/custom_import_logic.rs

@@ -29,8 +29,8 @@ impl TokioRuntime {
     ///
     /// This runs the given future on the current thread, blocking until it is complete, and yielding its resolved result. Any tasks or timers which the future spawns internally will be executed on the runtime.
     ///
-    /// When this is used on a `current_thread` runtime, only the [`Runtime::block_on`] method can drive the IO and timer drivers, but the `Handle::block_on` method cannot drive them.
-    /// This means that, when using this method on a `current_thread` runtime, anything that relies on IO or timers will not work unless there is another thread currently calling [`Runtime::block_on`] on the same runtime.
+    /// When this is used on a `current_thread` runtime, only the [`tokio::runtime::Runtime::block_on`] method can drive the IO and timer drivers, but the `Handle::block_on` method cannot drive them.
+    /// This means that, when using this method on a `current_thread` runtime, anything that relies on IO or timers will not work unless there is another thread currently calling [`tokio::runtime::Runtime::block_on`] on the same runtime.
     pub fn block_on<F, T>(&self, f: F) -> T
     where
         F: std::future::Future<Output = T>,

src/async_bridge.rs

@@ -0,0 +1 @@
+export * from "ext:deno_web/01_broadcast_channel.js";

src/ext/broadcast_channel/01_broadcast_channel.js

@@ -14,14 +14,29 @@ extension!(
     esm = [ dir "src/ext/broadcast_channel", "init_broadcast_channel.js" ],
 );
 
+extension!(
+    deno_broadcast_channel,
+    deps = [deno_web],
+    esm = [ dir "src/ext/broadcast_channel", "01_broadcast_channel.js" ],
+);
+
 impl ExtensionTrait<()> for init_broadcast_channel {
     fn init((): ()) -> Extension {
         init_broadcast_channel::init()
     }
 }
 
+impl ExtensionTrait<()> for deno_broadcast_channel {
+    fn init((): ()) -> Extension {
+        deno_broadcast_channel::init()
+    }
+}
+
 // Note: broadcast_channel functionality is now integrated into deno_web
 // No separate initialization is needed as it's handled by deno_web extension
 pub fn extensions(_channel: InMemoryBroadcastChannel, is_snapshot: bool) -> Vec<Extension> {
-    vec![init_broadcast_channel::build((), is_snapshot)]
+    vec![
+        deno_broadcast_channel::build((), is_snapshot),
+        init_broadcast_channel::build((), is_snapshot),
+    ]
 }

src/ext/broadcast_channel/mod.rs

@@ -1,10 +1,38 @@
 import * as _console from 'ext:deno_web/01_console.js';
 
-import { applyToGlobal, nonEnumerable } from 'ext:rustyscript/rustyscript.js';
-applyToGlobal({
-    console: nonEnumerable(
-      new _console.Console((msg, level) => globalThis.Deno.core.print(msg, level > 1)),
-    ),
-});
+import { applyToGlobal, nonEnumerable } from 'ext:rustyscript/rustyscript.js';
+
+const consoleInstance = new _console.Console((msg, level) =>
+  globalThis.Deno.core.print(msg, level > 1),
+);
+for (const name of [
+  "log",
+  "debug",
+  "info",
+  "warn",
+  "error",
+  "dir",
+  "dirxml",
+  "assert",
+  "clear",
+  "count",
+  "countReset",
+  "group",
+  "groupCollapsed",
+  "groupEnd",
+  "table",
+  "time",
+  "timeEnd",
+  "timeLog",
+  "trace",
+]) {
+  const value = consoleInstance[name];
+  if (typeof value === "function") {
+    consoleInstance[name] = value.bind(consoleInstance);
+  }
+}
+applyToGlobal({
+  console: nonEnumerable(consoleInstance),
+});
 
 globalThis.Deno.inspect = _console.inspect;

src/ext/console/init_console.js

@@ -1,20 +1,19 @@
-use deno_core::{extension, Extension};
-
-use super::ExtensionTrait;
-
-extension!(
-    init_console,
-    deps = [rustyscript, deno_web],
-    esm_entry_point = "ext:init_console/init_console.js",
-    esm = [ dir "src/ext/console", "init_console.js" ],
-);
-impl ExtensionTrait<()> for init_console {
-    fn init((): ()) -> Extension {
-        deno_terminal::colors::set_use_color(true);
-        init_console::init()
-    }
-}
-pub fn extensions(is_snapshot: bool) -> Vec<Extension> {
-    vec![<init_console as ExtensionTrait<()>>::build((), is_snapshot)]
-}
-
+use deno_core::{extension, Extension};
+
+use super::ExtensionTrait;
+
+extension!(
+    init_console,
+    deps = [rustyscript, deno_web],
+    esm_entry_point = "ext:init_console/init_console.js",
+    esm = [ dir "src/ext/console", "init_console.js" ],
+);
+impl ExtensionTrait<()> for init_console {
+    fn init((): ()) -> Extension {
+        deno_terminal::colors::set_use_color(true);
+        init_console::init()
+    }
+}
+pub fn extensions(is_snapshot: bool) -> Vec<Extension> {
+    vec![<init_console as ExtensionTrait<()>>::build((), is_snapshot)]
+}

src/ext/console/mod.rs

@@ -203,7 +203,7 @@ fn console_size_from_fd(fd: std::os::unix::prelude::RawFd) -> Result<ConsoleSize
     // SAFETY: libc calls
     unsafe {
         let mut size: libc::winsize = std::mem::zeroed();
-        if libc::ioctl(fd, libc::TIOCGWINSZ, &mut size as *mut _) != 0 {
+        if libc::ioctl(fd, libc::TIOCGWINSZ, std::ptr::from_mut(&mut size)) != 0 {
             return Err(Error::last_os_error());
         }
         Ok(ConsoleSize {