Add missing GC_GUARD in fbuffer_append_str

byroot · byroot · commit 13689c269970 · 2026-03-08T10:12:00.000+01:00
Ref: fff25c9 `StringValuePtr` use `volatile` so the compiler is less likely to re-use the register. But regardless, we should GC_GUARD `str` as we no longer reference it after `GETMEM`.
diff --git a/ext/json/ext/fbuffer/fbuffer.h b/ext/json/ext/fbuffer/fbuffer.h
@@ -166,6 +166,7 @@ static void fbuffer_append_str(FBuffer *fb, VALUE str)
     RSTRING_GETMEM(str, ptr, len);
 
     fbuffer_append(fb, ptr, len);
+    RB_GC_GUARD(str);
 }
 
 static void fbuffer_append_str_repeat(FBuffer *fb, VALUE str, size_t repeat)
@@ -182,6 +183,7 @@ static void fbuffer_append_str_repeat(FBuffer *fb, VALUE str, size_t repeat)
         fbuffer_append_reserved(fb, ptr, len);
         repeat--;
     }
+    RB_GC_GUARD(str);
 }
 
 static inline void fbuffer_append_char(FBuffer *fb, char newchr)

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ static void fbuffer_append_str(FBuffer *fb, VALUE str)`
`166`	`166`	`RSTRING_GETMEM(str, ptr, len);`
`167`	`167`
`168`	`168`	`fbuffer_append(fb, ptr, len);`
	`169`	`+ RB_GC_GUARD(str);`
`169`	`170`	`}`
`170`	`171`
`171`	`172`	`static void fbuffer_append_str_repeat(FBuffer *fb, VALUE str, size_t repeat)`
`@@ -182,6 +183,7 @@ static void fbuffer_append_str_repeat(FBuffer *fb, VALUE str, size_t repeat)`
`182`	`183`	`fbuffer_append_reserved(fb, ptr, len);`
`183`	`184`	`repeat--;`
`184`	`185`	`}`
	`186`	`+ RB_GC_GUARD(str);`
`185`	`187`	`}`
`186`	`188`
`187`	`189`	`static inline void fbuffer_append_char(FBuffer *fb, char newchr)`