Set up new page for case contacts table

.github/workflows/rspec.yml

@@ -68,20 +68,15 @@ jobs:
           bundle exec rake db:schema:load
           bundle exec rails assets:precompile
 
-      - name: Run rspec and upload code coverage
+      - name: Run rspec
         env:
           DATABASE_HOST: localhost
           POSTGRES_USER: postgres
           CASA_DATABASE_PASSWORD: password
           POSTGRES_HOST_AUTH_METHOD: trust
           RUN_SIMPLECOV: true
-          CC_TEST_REPORTER_ID: 31464536e34ab26588cb951d0fa6b5898abdf401dbe912fd47274df298e432ac
         run: |
-          curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-          chmod +x ./cc-test-reporter
-          ./cc-test-reporter before-build
           RUBYOPT='-W:no-deprecated -W:no-experimental' bundle exec rspec
-          ./cc-test-reporter after-build --exit-code $?
 
       - name: Archive selenium screenshots
         if: ${{ failure() }}

app/controllers/case_contacts/case_contacts_new_design_controller.rb

@@ -0,0 +1,15 @@
+class CaseContacts::CaseContactsNewDesignController < ApplicationController
+  include LoadsCaseContacts
+
+  def index
+    load_case_contacts
+  end
+
+  def datatable
+    authorize CaseContact
+    case_contacts = policy_scope(current_organization.case_contacts)
+    datatable = CaseContactDatatable.new case_contacts, params
+
+    render json: datatable
+  end
+end

app/controllers/case_contacts_controller.rb

@@ -1,30 +1,15 @@
 # frozen_string_literal: true
 
 class CaseContactsController < ApplicationController
+  include LoadsCaseContacts
+
   before_action :set_case_contact, only: %i[edit destroy]
   before_action :set_contact_types, only: %i[new edit create]
   before_action :require_organization!
   after_action :verify_authorized, except: %i[leave]
 
   def index
-    authorize CaseContact
-
-    @current_organization_groups = current_organization_groups
-
-    @filterrific = initialize_filterrific(
-      all_case_contacts,
-      params[:filterrific],
-      select_options: {
-        sorted_by: CaseContact.options_for_sorted_by
-      }
-    ) || return
-
-    @pagy, @filtered_case_contacts = pagy(@filterrific.find)
-    case_contacts = CaseContact.case_hash_from_cases(@filtered_case_contacts)
-    case_contacts = case_contacts.select { |k, _v| current_user.casa_cases.pluck(:id).include?(k) } if current_user.volunteer?
-    case_contacts = case_contacts.select { |k, _v| k == params[:casa_case_id].to_i } if params[:casa_case_id].present?
-
-    @presenter = CaseContactPresenter.new(case_contacts)
+    load_case_contacts
   end
 
   def drafts
@@ -96,24 +81,6 @@ def set_contact_types
     @contact_types = ContactType.for_organization(current_organization)
   end
 
-  def current_organization_groups
-    current_organization.contact_type_groups
-      .includes(:contact_types)
-      .joins(:contact_types)
-      .where(contact_types: {active: true})
-      .uniq
-  end
-
-  def all_case_contacts
-    policy_scope(current_organization.case_contacts).preload(
-      :creator,
-      :followups,
-      contact_types: :contact_type_group,
-      contact_topic_answers: :contact_topic,
-      casa_case: :volunteers
-    )
-  end
-
   def additional_expense_params
     @additional_expense_params ||= AdditionalExpenseParamsService.new(params).calculate
   end

app/controllers/concerns/loads_case_contacts.rb

@@ -0,0 +1,44 @@
+module LoadsCaseContacts
+  extend ActiveSupport::Concern
+
+  private
+
+  def load_case_contacts
+    authorize CaseContact
+
+    @current_organization_groups = current_organization_groups
+
+    @filterrific = initialize_filterrific(
+      all_case_contacts,
+      params[:filterrific],
+      select_options: {
+        sorted_by: CaseContact.options_for_sorted_by
+      }
+    ) || return
+
+    @pagy, @filtered_case_contacts = pagy(@filterrific.find)
+    case_contacts = CaseContact.case_hash_from_cases(@filtered_case_contacts)
+    case_contacts = case_contacts.slice(*current_user.casa_cases.pluck(:id)) if current_user.volunteer?
+    case_contacts = case_contacts.select { |k, _v| k == params[:casa_case_id].to_i } if params[:casa_case_id].present?
+
+    @presenter = CaseContactPresenter.new(case_contacts)
+  end
+
+  def current_organization_groups
+    current_organization.contact_type_groups
+      .includes(:contact_types)
+      .joins(:contact_types)
+      .where(contact_types: {active: true})
+      .uniq
+  end
+
+  def all_case_contacts
+    policy_scope(current_organization.case_contacts).preload(
+      :creator,
+      :followups,
+      contact_types: :contact_type_group,
+      contact_topic_answers: :contact_topic,
+      casa_case: :volunteers
+    )
+  end
+end

app/decorators/case_contact_decorator.rb

@@ -61,6 +61,14 @@ def contact_types
     end
   end
 
+  def contact_types_comma_separated
+    if object.contact_types.any?
+      object.contact_types&.map { |ct| ct.name }&.join(", ")
+    else
+      "No contact type specified"
+    end
+  end
+
   def report_contact_types
     object.contact_types&.map { |ct| ct.name }&.join("|")
   end

app/javascript/src/dashboard.js

@@ -8,7 +8,11 @@ const defineCaseContactsTable = function () {
     {
       scrollX: true,
       searching: false,
-      order: [[0, 'desc']]
+      order: [[2, 'desc']],
+      columnDefs: [
+        { type: 'date', targets: 2 },
+        { orderable: false, targets: [0, 1, -1] } // disable sort on bell, chevron, vertical elipses menu
+      ]
     }
   )
 }

app/views/case_contacts/case_contacts_new_design/index.html.erb

@@ -0,0 +1,98 @@
+<div class="title-wrapper pt-30">
+  <div class="row align-items-center">
+      <div class="title mb-30">
+        <h1>Case Contacts</h1>
+      </div>
+  </div>
+</div>
+
+<div class="card-style mb-30">
+  <div class="table-wrapper">
+    <table
+      id="case_contacts"
+      class="table"
+      data-source="<%= datatable_case_contacts_path format: :json %>">
+      <thead>
+      <tr>
+        <th data-orderable="false"></th>
+        <th data-orderable="false"></th>
+        <th><h6>Date</h6></th>
+        <th><h6>Case</h6></th>
+        <th><h6>Relationship</h6></th>
+        <th><h6>Medium</h6></th>
+        <th><h6>Created By</h6></th>
+        <th><h6>Contacted</h6></th>
+        <th><h6>Topics</h6></th>
+        <th><h6>Draft</h6></th>
+        <th data-orderable="false"></th>
+      </tr>
+      <!-- end table row-->
+      </thead>
+      <tbody>
+        <% @presenter.case_contacts.each do |casa_case_id, case_contacts| %>
+          <% case_contacts.each do |case_contact| %>
+            <tr data-testid="case_contact-row">
+              <td>
+                <i class='fas fa-bell'></i>
+              </td>
+              <td>
+                <i class="fa-solid fa-chevron-down"></i>
+              </td>
+              <td>
+                <%= I18n.l(case_contact[:occurred_at], format: :full) if case_contact[:occurred_at].present? %>
+              </td>
+              <td>
+                <%= @presenter.display_case_number(casa_case_id) %>
+              </td>
+              <td>
+                <%= case_contact.decorate.contact_types_comma_separated %>
+              </td>
+              <td>
+                <%= case_contact.medium_type&.capitalize %>
+              </td>
+              <td>
+                <% if policy(case_contact).edit? %>
+                  <% if current_user.volunteer? %>
+                    <%= case_contact.creator&.display_name %>
+                  <% else %>
+                    <% if case_contact.creator&.supervisor? %>
+                      <%= link_to case_contact.creator&.display_name, edit_supervisor_path(case_contact.creator), data: { turbo: false } %>
+                    <% elsif case_contact.creator&.casa_admin? %>
+                      <%= link_to case_contact.creator&.display_name, edit_users_path, data: { turbo: false } %>
+                    <% else %>
+                      <%= link_to case_contact.creator&.display_name, edit_volunteer_path(case_contact.creator), data: { turbo: false } %>
+                    <% end %>
+                  <% end %>
+                <% else %>
+                  <%= case_contact.creator&.display_name %>
+                <% end %>
+              </td>
+              <td>
+                <% if case_contact.contact_made %>
+                  <i class="lni lni-checkmark-circle" style="color: green;"></i>
+                <% else %>
+                  <i class="lni lni-cross-circle" style="color: orange;"></i>
+                <% end %>
+                <%= "(#{"%02d:%02d" % [case_contact.duration_minutes / 60, case_contact.duration_minutes % 60]})" if case_contact.duration_minutes %>
+              </td>
+              <td>
+                <%= case_contact.contact_topics.map(&:question).join(" | ") %>
+              </td>
+              <td>
+                <% if !case_contact.active? %>
+                  <span class="badge badge-pill light-bg text-black" data-testid="draft-badge">
+                    Draft
+                  </span>
+                <% end %>
+              </td>
+              <td>
+                <i class="fas fa-ellipsis-v"></i>
+              </td>
+            </tr>
+          <% end %>
+        <% end %>
+      </tbody>
+    </table>
+    <!-- end table -->
+  </div>
+</div>

config/routes.rb

@@ -92,7 +92,8 @@
 
   get "case_contacts/leave", to: "case_contacts#leave", as: "leave_case_contacts_form"
   get "case_contacts/drafts", to: "case_contacts#drafts"
-  resources :case_contacts, except: %i[create update show] do
+  get "case_contacts/new_design", to: "case_contacts/case_contacts_new_design#index"
+  resources :case_contacts, except: %i[create update show], concerns: %i[with_datatable] do
     member do
       post :restore
     end

spec/controllers/concerns/loads_case_contacts_spec.rb

@@ -0,0 +1,15 @@
+require "rails_helper"
+
+RSpec.describe LoadsCaseContacts do
+  let(:host) do
+    Class.new do
+      include LoadsCaseContacts
+    end
+  end
+
+  it "exists and defines private API" do
+    expect(described_class).to be_a(Module)
+    expect(host.private_instance_methods)
+      .to include(:load_case_contacts, :current_organization_groups, :all_case_contacts)
+  end
+end

spec/requests/case_contacts/case_contacts_new_design_spec.rb

@@ -0,0 +1,43 @@
+require "rails_helper"
+
+RSpec.describe "/case_contacts_new_design", type: :request do
+  let(:organization) { create(:casa_org) }
+  let(:admin) { create(:casa_admin, casa_org: organization) }
+
+  before { sign_in admin }
+
+  describe "GET /index" do
+    subject(:request) do
+      get case_contacts_new_design_path
+
+      response
+    end
+
+    let!(:casa_case) { create(:casa_case, casa_org: organization) }
+    let!(:past_contact) { create(:case_contact, :active, casa_case: casa_case, occurred_at: 3.weeks.ago) }
+    let!(:recent_contact) { create(:case_contact, :active, casa_case: casa_case, occurred_at: 3.days.ago) }
+    let!(:draft_contact) { create(:case_contact, casa_case: casa_case, occurred_at: 5.days.ago, status: "started") }
+
+    it { is_expected.to have_http_status(:success) }
+
+    it "lists exactly two active contacts and one draft" do
+      doc = Nokogiri::HTML(request.body)
+      case_contact_rows = doc.css('[data-testid="case_contact-row"]')
+      expect(case_contact_rows.size).to eq(3)
+    end
+
+    it "shows the draft badge exactly once" do
+      doc = Nokogiri::HTML(request.body)
+      expect(doc.css('[data-testid="draft-badge"]').count).to eq(1)
+    end
+
+    it "orders contacts by occurred_at desc" do
+      body = request.body
+
+      recent_index = body.index(I18n.l(recent_contact.occurred_at, format: :full))
+      past_index = body.index(I18n.l(past_contact.occurred_at, format: :full))
+
+      expect(recent_index).to be < past_index
+    end
+  end
+end