Skip to content

Commit 8000495

Browse files
authored
fix(scenarios): update parameters for manually maintained start_run_and_await_env_ready methods (#692)
* update parameters for manually maintained start_run_and_await_env_ready methods * added helper comment (maintains consistency)
1 parent 8551307 commit 8000495

1 file changed

Lines changed: 22 additions & 10 deletions

File tree

src/runloop_api_client/resources/scenarios/scenarios.py

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
ScorersResourceWithStreamingResponse,
3131
AsyncScorersResourceWithStreamingResponse,
3232
)
33-
from ..._types import NOT_GIVEN, Body, Omit, Query, Headers, NotGiven, SequenceNotStr, omit, not_given
33+
from ..._types import Body, Omit, Query, Headers, NotGiven, SequenceNotStr, omit, not_given
3434
from ..._utils import maybe_transform, async_maybe_transform
3535
from ..._compat import cached_property
3636
from ..._resource import SyncAPIResource, AsyncAPIResource
@@ -457,17 +457,17 @@ def start_run_and_await_env_ready(
457457
self,
458458
*,
459459
scenario_id: str,
460-
benchmark_run_id: Optional[str] | NotGiven = NOT_GIVEN,
461-
metadata: Optional[Dict[str, str]] | NotGiven = NOT_GIVEN,
462-
run_name: Optional[str] | NotGiven = NOT_GIVEN,
463-
run_profile: Optional[scenario_start_run_params.RunProfile] | NotGiven = NOT_GIVEN,
460+
benchmark_run_id: Optional[str] | Omit = omit,
461+
metadata: Optional[Dict[str, str]] | Omit = omit,
462+
run_name: Optional[str] | Omit = omit,
463+
run_profile: Optional[scenario_start_run_params.RunProfile] | Omit = omit,
464464
polling_config: PollingConfig | None = None,
465465
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
466466
# The extra values given here take precedence over values defined on the client or passed to this method.
467467
extra_headers: Headers | None = None,
468468
extra_query: Query | None = None,
469469
extra_body: Body | None = None,
470-
timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
470+
timeout: float | httpx.Timeout | None | NotGiven = not_given,
471471
idempotency_key: str | None = None,
472472
) -> ScenarioRunView:
473473
"""Start a new ScenarioRun and wait for its environment to be ready.
@@ -913,11 +913,18 @@ async def start_run(
913913
async def start_run_and_await_env_ready(
914914
self,
915915
scenario_id: str,
916-
benchmark_run_id: Optional[str] | NotGiven = NOT_GIVEN,
917-
metadata: Optional[Dict[str, str]] | NotGiven = NOT_GIVEN,
918-
run_name: Optional[str] | NotGiven = NOT_GIVEN,
919-
run_profile: Optional[scenario_start_run_params.RunProfile] | NotGiven = NOT_GIVEN,
916+
benchmark_run_id: Optional[str] | Omit = omit,
917+
metadata: Optional[Dict[str, str]] | Omit = omit,
918+
run_name: Optional[str] | Omit = omit,
919+
run_profile: Optional[scenario_start_run_params.RunProfile] | Omit = omit,
920920
polling_config: PollingConfig | None = None,
921+
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
922+
# The extra values given here take precedence over values defined on the client or passed to this method.
923+
extra_headers: Headers | None = None,
924+
extra_query: Query | None = None,
925+
extra_body: Body | None = None,
926+
timeout: float | httpx.Timeout | None | NotGiven = not_given,
927+
idempotency_key: str | None = None,
921928
) -> ScenarioRunView:
922929
"""Start a new ScenarioRun and wait for its environment to be ready.
923930
@@ -941,6 +948,11 @@ async def start_run_and_await_env_ready(
941948
metadata=metadata,
942949
run_name=run_name,
943950
run_profile=run_profile,
951+
extra_headers=extra_headers,
952+
extra_query=extra_query,
953+
extra_body=extra_body,
954+
timeout=timeout,
955+
idempotency_key=idempotency_key,
944956
)
945957

946958
await self._client.devboxes.await_running(

0 commit comments

Comments
 (0)