Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/llvm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2a1cdeadd3ea8e1eba9cc681037b83f07332763b
Choose a base ref
...
head repository: rust-lang/llvm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5a081f0363340dd895d0958955d0c84661f60f05
Choose a head ref
  • 4 commits
  • 5 files changed
  • 3 contributors

Commits on Sep 6, 2018

  1. [SROA] Fix alignment for uses of PHI nodes. 

    Splitting an alloca can decrease the alignment of GEPs into the
partition.  Normally, rewriting accounts for this, but the code was
missing for uses of PHI nodes and select instructions.

Fixes https://bugs.llvm.org/show_bug.cgi?id=38707 .

Differential Revision: https://reviews.llvm.org/D51335



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341094 91177308-0d34-0410-b5e6-96231b3b80d8
    @arielb1
    Eli Friedman authored and arielb1 committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    7e41493 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #125 from arielb1/phi-alignment 

    [SROA] Fix alignment for uses of PHI nodes.
    @alexcrichton
    alexcrichton authored Sep 6, 2018
    Configuration menu
    Copy the full SHA
    284b1ce View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. [GlobalISel] Lower dbg.declare into indirect DBG_VALUE 

    Summary:
D31439 changed the semantics of dbg.declare to take the address of a
variable as the first argument, making it indirect.  It specifically
updated FastISel for this change here:

https://reviews.llvm.org/D31439#change-WVArzi177jPl

GlobalISel needs to follow suit, or else it will be missing a level of
indirection in the generated debuginfo.  This problem was seen in a Rust
debuginfo test on aarch64, since GlobalISel is used at -O0 for aarch64.

rust-lang/rust#49807
https://bugzilla.redhat.com/show_bug.cgi?id=1611597
https://bugzilla.redhat.com/show_bug.cgi?id=1625768

Reviewers: dblaikie, aprantl, t.p.northover, javed.absar, rnk

Reviewed By: rnk

Subscribers: #debug-info, rovka, kristof.beyls, JDevlieghere, llvm-commits, tstellar

Differential Revision: https://reviews.llvm.org/D51749

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341969 91177308-0d34-0410-b5e6-96231b3b80d8
    @cuviper
    cuviper committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    1c34cd5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #126 from cuviper/rust-global-isel-dbg.declare 

    [GlobalISel] Lower dbg.declare into indirect DBG_VALUE
    @alexcrichton
    alexcrichton authored Sep 11, 2018
    Configuration menu
    Copy the full SHA
    5a081f0 View commit details
    Browse the repository at this point in the history
Loading