Fix review comments

Author: bjorn3

compiler/rustc_codegen_ssa/src/target_features.rs

@@ -142,7 +142,7 @@ pub(crate) fn check_target_feature_trait_unsafe(tcx: TyCtxt<'_>, id: LocalDefId,
 /// Parse the value of the target spec `features` field or `-Ctarget-feature`, also expanding
 /// implied features, and call the closure for each (expanded) Rust feature. If the list contains
 /// a syntactically invalid item (not starting with `+`/`-`), the error callback is invoked.
-fn parse_rust_feature_flag<'a>(
+fn parse_rust_feature_list<'a>(
     sess: &'a Session,
     features: &'a str,
     err_callback: impl Fn(&'a str),
@@ -245,7 +245,7 @@ pub fn cfg_target_feature<'a, const N: usize>(
     let mut enabled_disabled_features = FxHashMap::default();
 
     // Add enabled and remove disabled features.
-    parse_rust_feature_flag(
+    parse_rust_feature_list(
         sess,
         &sess.opts.cg.target_feature,
         /* err_callback */
@@ -378,7 +378,7 @@ pub fn target_spec_to_backend_features<'a>(
 ) {
     // Compute implied features
     let mut rust_features = vec![];
-    parse_rust_feature_flag(
+    parse_rust_feature_list(
         sess,
         &sess.target.features,
         /* err_callback */
@@ -409,7 +409,7 @@ pub fn flag_to_backend_features<'a>(
 ) {
     // Compute implied features
     let mut rust_features = vec![];
-    parse_rust_feature_flag(
+    parse_rust_feature_list(
         sess,
         &sess.opts.cg.target_feature,
         /* err_callback */

compiler/rustc_interface/src/util.rs

@@ -364,6 +364,7 @@ impl CodegenBackend for DummyCodegenBackend {
     }
 
     fn target_config(&self, sess: &Session) -> TargetConfig {
+        let abi_required_features = sess.target.abi_required_features();
         let (target_features, unstable_target_features) = cfg_target_feature::<0>(
             sess,
             |_feature| Default::default(),
@@ -372,7 +373,7 @@ impl CodegenBackend for DummyCodegenBackend {
                 // It would be better to parse target.features instead and handle implied features,
                 // but target.features doesn't contain features that are enabled by default for an
                 // architecture or target cpu.
-                sess.target.abi_required_features().required.contains(&feature)
+                abi_required_features.required.contains(&feature)
             },
         );
 

compiler/rustc_target/src/spec/mod.rs

@@ -2246,10 +2246,10 @@ pub struct TargetOptions {
     /// Whether a cpu needs to be explicitly set.
     /// Set to true if there is no default cpu. Defaults to false.
     pub need_explicit_cpu: bool,
-    /// Default target features to pass to LLVM. These features overwrite
-    /// `-Ctarget-cpu` but can be overwritten with `-Ctarget-features`.
-    /// Corresponds to `llc -mattr=$llvm_features` where `$llvm_features` is the result of mapping
-    /// the Rust features in this field to LLVM features.
+    /// Default (Rust) target features to enable for this target. These features
+    /// overwrite `-Ctarget-cpu` but can be overwritten with `-Ctarget-features`.
+    /// Corresponds to `llc -mattr=$llvm_features` where `$llvm_features` is the
+    /// result of mapping the Rust features in this field to LLVM features.
     ///
     /// Generally it is a bad idea to use negative target features because they often interact very
     /// poorly with how `-Ctarget-cpu` works. Instead, try to use a lower "base CPU" and enable the