feat: Add TryFromIntError::kind#153178
Draft
sorairolake wants to merge 1 commit intorust-lang:mainfrom
Draft
Conversation
Contributor
Author
|
@rustbot label +T-libs-api -T-libs |
d40d08a to
38cf8bf
Compare
38cf8bf to
20c70f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryFromIntError::kindmethod libs-team#746This pull request adds
kindmethod toTryFromIntError, which outputs the detailed cause of converting an integer failing.This is primarily intended for use in cases where there are multiple causes for failure, such as converting from a large signed integer type to a small signed integer type.
At the moment, this method returns
&IntErrorKind. This type implements theCopytrait and could returnIntErrorKind, but returns a reference to align with the behavior ofParseIntError::kind. If it is not necessary to align the behavior ofTryFromIntError::kindwithParseIntError::kind, I'll change this method to returnIntErrorKind.Before this pull request,
IntErrorKindwas only used byParseIntError, but I changed it to be used byTryFromIntErroras well, so I updatedIntErrorKind's documentation.impl TryFrom<usize> for AlignmentreturnsTryFromIntErroras an error if the given value is not a power of two. However,IntErrorKinddoes not have a variant that represents this. So I added the variantNotAPowerOfTwoto represent this.