remove UnevaluatedConstKind::def_id by khyperia · Pull Request #157374 · rust-lang/rust

khyperia · 2026-06-03T10:25:59Z

this is some of the const side of #152245

not quite a full removal, there's still some spicy things such as UnevaluatedConstKind::def_span remaining that won't quite work for new non-DefID UnevaluatedConstKind cases, but IMO this is the bulk of the work, and feature-specific things can deal with their quirks in their own PRs when they know their own use cases.

r? @BoxyUwU

self-reminder: file an issue on what to do about rustc_public's handling of the raw DefIds in rustc_public AliasTy/AliasConst

rustbot · 2026-06-03T10:26:02Z

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

changes to the core type system

cc @lcnr

Some changes occurred in abstract_const.rs

cc @BoxyUwU

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-06-03T10:26:05Z

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-06-04T04:36:30Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

BoxyUwU · 2026-06-05T15:45:21Z

-    fn is_const_param_default(tcx: TyCtxt<'_>, def: LocalDefId) -> bool {
-        let hir_id = tcx.local_def_id_to_hir_id(def);
+    fn is_const_param_default(tcx: TyCtxt<'_>, kind: ty::UnevaluatedConstKind<'_>) -> bool {
+        let def_id = match kind {


this fn is really a "is this anon const a default for a const prameter" so we dont really care about other alias kinds than Anon

View changes since the review

BoxyUwU · 2026-06-05T15:46:20Z

-                if mir_body.is_polymorphic {
-                    let Some(local_def_id) = ct.kind.def_id().as_local() else { return };
+                if mir_body.is_polymorphic
+                    && let Some(def_id) = ct.kind.opt_def_id()


should just be able to use cid.instance.def_id() here

View changes since the review

just pushed fixes for both feedbacks, thanks ✨

BoxyUwU · 2026-06-07T20:45:28Z

@bors r+ rollup=never

sick, thanks :3

rust-bors · 2026-06-07T20:45:30Z

📌 Commit f1099c0 has been approved by BoxyUwU

It is now in the queue for this repository.

@BoxyUwU

…r=BoxyUwU remove UnevaluatedConstKind::def_id this is some of the const side of #152245 not quite a _full_ removal, there's still some spicy things such as `UnevaluatedConstKind::def_span` remaining that won't quite work for new non-DefID `UnevaluatedConstKind` cases, but IMO this is the bulk of the work, and feature-specific things can deal with their quirks in their own PRs when they know their own use cases. r? @BoxyUwU self-reminder: file an issue on what to do about rustc_public's handling of the raw DefIds in rustc_public AliasTy/AliasConst

rust-bors · 2026-06-08T01:22:43Z

💔 Test for e8a10b1 failed: CI. Failed job:

auto - i686-gnu-nopt-1 (web logs, enhanced plaintext logs)

jhpratt · 2026-06-08T01:39:16Z

@bors retry

rust-log-analyzer · 2026-06-08T01:47:00Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

jhpratt · 2026-06-08T03:14:40Z

Let's see if CI will cooperate

@bors p=100

@BoxyUwU

…r=BoxyUwU remove UnevaluatedConstKind::def_id this is some of the const side of #152245 not quite a _full_ removal, there's still some spicy things such as `UnevaluatedConstKind::def_span` remaining that won't quite work for new non-DefID `UnevaluatedConstKind` cases, but IMO this is the bulk of the work, and feature-specific things can deal with their quirks in their own PRs when they know their own use cases. r? @BoxyUwU self-reminder: file an issue on what to do about rustc_public's handling of the raw DefIds in rustc_public AliasTy/AliasConst

rust-bors · 2026-06-08T03:22:28Z

💔 Test for bac7ec3 failed: CI. Failed job:

auto - dist-powerpc64le-linux-gnu (web logs, enhanced plaintext logs)

jhpratt · 2026-06-08T03:23:38Z

@bors p=0 retry

jhpratt · 2026-06-08T03:24:08Z

@bors retry

rust-log-analyzer · 2026-06-08T03:29:12Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@BoxyUwU

…r=BoxyUwU remove UnevaluatedConstKind::def_id this is some of the const side of #152245 not quite a _full_ removal, there's still some spicy things such as `UnevaluatedConstKind::def_span` remaining that won't quite work for new non-DefID `UnevaluatedConstKind` cases, but IMO this is the bulk of the work, and feature-specific things can deal with their quirks in their own PRs when they know their own use cases. r? @BoxyUwU self-reminder: file an issue on what to do about rustc_public's handling of the raw DefIds in rustc_public AliasTy/AliasConst

jhpratt · 2026-06-08T05:02:22Z

@bors yield

tree is closed due to docker

rust-bors · 2026-06-08T05:02:26Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27117029281

The next pull request likely to be tested is #155607.

rust-bors · 2026-06-08T16:43:35Z

☀️ Test successful - CI
Approved by: BoxyUwU
Duration: 3h 18m 49s
Pushing f3ef3bd to main...

github-actions · 2026-06-08T16:46:57Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 877a131 (parent) -> f3ef3bd (this PR)

Test differences

Show 14 test diffs

14 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f3ef3bd882dd24a275a60701a67c3bb330edd8c1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-i686-mingw: 1h 36m -> 2h 38m (+65.5%)
aarch64-apple: 2h 32m -> 3h 11m (+25.7%)
x86_64-gnu: 1h 51m -> 2h 17m (+23.7%)
dist-ohos-x86_64: 1h 3m -> 1h 18m (+22.3%)
arm-android: 1h 45m -> 1h 22m (-21.5%)
dist-powerpc64-linux-musl: 1h 45m -> 2h 7m (+21.1%)
aarch64-gnu: 2h 9m -> 2h 24m (+11.2%)
dist-aarch64-msvc: 1h 45m -> 1h 56m (+10.5%)
test-various: 1h 59m -> 2h 11m (+10.4%)
dist-aarch64-freebsd: 58m 56s -> 1h 4m (+10.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-08T17:25:43Z

Finished benchmarking commit (f3ef3bd): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Max RSS (memory usage)

Results (secondary -6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.5%	[-6.5%, -6.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.4%, -2.4%]	2
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 516.107s -> 517.572s (0.28%)
Artifact size: 401.34 MiB -> 400.85 MiB (-0.12%)

Mark-Simulacrum · 2026-06-09T01:19:09Z

All regressions look like noise (though recently introduced).

@rustbot label +perf-regression-triaged

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2026

rustbot assigned BoxyUwU Jun 3, 2026

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 3, 2026

This comment has been minimized.

Sign in to view

khyperia force-pushed the remove-UnevaluatedConstKind-def_id branch from 10e75d3 to 5070cba Compare June 4, 2026 04:36

BoxyUwU reviewed Jun 5, 2026

View reviewed changes

remove UnevaluatedConstKind::def_id

f1099c0

khyperia force-pushed the remove-UnevaluatedConstKind-def_id branch from 5070cba to f1099c0 Compare June 6, 2026 08:54

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 8, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2026

rust-bors Bot merged commit f3ef3bd into rust-lang:main Jun 8, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 8, 2026

khyperia deleted the remove-UnevaluatedConstKind-def_id branch June 8, 2026 16:44

rust-bors Bot mentioned this pull request Jun 8, 2026

[Experiment] Add rigid alias marker #156742

Draft

rustbot added the perf-regression Performance regression. label Jun 8, 2026

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 9, 2026

Uh oh!

Conversation

khyperia commented Jun 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 3, 2026

Uh oh!

rustbot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jun 4, 2026

Uh oh!

BoxyUwU Jun 5, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU Jun 5, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khyperia Jun 6, 2026

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Jun 7, 2026

Uh oh!

rust-bors Bot commented Jun 7, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 8, 2026

Uh oh!

jhpratt commented Jun 8, 2026

Uh oh!

rust-log-analyzer commented Jun 8, 2026

Uh oh!

jhpratt commented Jun 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 8, 2026

Uh oh!

jhpratt commented Jun 8, 2026

Uh oh!

jhpratt commented Jun 8, 2026

Uh oh!

rust-log-analyzer commented Jun 8, 2026

Uh oh!

This comment has been minimized.

jhpratt commented Jun 8, 2026

Uh oh!

rust-bors Bot commented Jun 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 8, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 8, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Mark-Simulacrum commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

khyperia commented Jun 3, 2026 •

edited by rustbot

Loading

BoxyUwU Jun 5, 2026 •

edited by rustbot

Loading

BoxyUwU Jun 5, 2026 •

edited by rustbot

Loading