Skip to content

Fix #157551: links to WASI __wasi_clock_time_get were broken#157552

Closed
curiousdannii wants to merge 1 commit into
rust-lang:mainfrom
curiousdannii:patch-1
Closed

Fix #157551: links to WASI __wasi_clock_time_get were broken#157552
curiousdannii wants to merge 1 commit into
rust-lang:mainfrom
curiousdannii:patch-1

Conversation

@curiousdannii

@curiousdannii curiousdannii commented Jun 7, 2026

Copy link
Copy Markdown

Fix #157551: links to WASI __wasi_clock_time_get were broken

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 7, 2026
@rustbot

rustbot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @clarfonthey (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 11 candidates
  • Random selection from Mark-Simulacrum, aapoalas, clarfonthey, jhpratt

@rustbot

rustbot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@joboet

joboet commented Jun 7, 2026

Copy link
Copy Markdown
Member

Thanks! But I don't think we use __wasi_clock_time_get any more anyway, #147572 switched WASI to use the clock_gettime from wasi-libc. So this should probably use the same link as the other UNIXes.

@bjorn3

bjorn3 commented Jun 7, 2026

Copy link
Copy Markdown
Member

#157452 fixes this and a bunch of other wasi spec links.

@joboet joboet mentioned this pull request Jun 7, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

std::time::SystemTime link for __wasi_clock_time_get is broken

5 participants