Skip to content

deprecate --help -v#22495

Closed
richo wants to merge 3 commits into
rust-lang:masterfrom
richo:richo-all-help
Closed

deprecate --help -v#22495
richo wants to merge 3 commits into
rust-lang:masterfrom
richo:richo-all-help

Conversation

@richo

@richo richo commented Feb 18, 2015

Copy link
Copy Markdown
Contributor

the verbose option to help shows only a few extra lines, so just show
them all by default and save some time and keystrokes

The diff that -v introduced on the output of rustc --help was only:

--- /tmp/help   2015-02-18 10:49:59.000000000 -0800
+++ /tmp/help-v 2015-02-18 10:50:03.000000000 -0800
@@ -34,10 +34,16 @@
                         Set a codegen option
     -V --version        Print version info and exit
     -v --verbose        Use verbose output
+    --extern NAME=PATH  Specify where an external rust library is located
+    --sysroot PATH      Override the system root
+    -Z FLAG             Set internal debugging options
+    --color auto|always|never
+                        Configure coloring of output: auto = colorize, if
+                        output goes to a tty (default); always = always
+                        colorize output; never = never colorize output

 Additional help:
     -C help             Print codegen options
     -W help             Print 'lint' options and default settings
     -Z help             Print internal options for debugging rustc
-    --help -v           Print the full set of options rustc accepts

the verbose option to help shows only a few extra lines, so just show
them all by default and save some time and keystrokes
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

While there are not particularly many more options in --help -v today, it is planned that likely many new flavorful options to the compiler will land there instead of in --help. (e.g. this was designed with future extensibility in mind).

@richo

richo commented Feb 19, 2015

Copy link
Copy Markdown
Contributor Author

Sure. I guess the counterargument is that it's a fairly bizarre feature, especially when it masks some interesting options, eg if I wanted to know how to uncolor the output the first thing I would try would be

rustc --help | grep color

My intuition is that this should be removed, and reconsidered if the help text is getting out of control. I'm pretty sure that a middleground solution, like leaving all the plumbing around, but still showing the whole help message is the worst outcome. As it stands, the verbose output is only 49 lines.

@alexcrichton

Copy link
Copy Markdown
Member

cc @brson, @pnkfelix, @cmr (we discussed this at the work week)

@emberian

Copy link
Copy Markdown
Contributor

I'm pretty neutral on this issue. I have sympathy for both arguments, but I think that hiding arguments might be more annoying than having lots of output in the long run.

@huonw

huonw commented Mar 1, 2015

Copy link
Copy Markdown
Contributor

r? @alexcrichton (reassigning, also ping)

@rust-highfive rust-highfive assigned alexcrichton and unassigned huonw Mar 1, 2015
@richo

richo commented Mar 9, 2015

Copy link
Copy Markdown
Contributor Author

ping?

@bors

bors commented Mar 12, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #23298) made this pull request unmergeable. Please resolve the merge conflicts.

@richo

richo commented Mar 12, 2015

Copy link
Copy Markdown
Contributor Author

Is it worth me rebasing this?

@alexcrichton

Copy link
Copy Markdown
Member

My feelings here haven't changed, but you may want to reach out to @brson or @pnkfelix on IRC to get their feeling on this as well.

@pnkfelix

Copy link
Copy Markdown
Contributor

I'm with @alexcrichton ; I think the situation now is a better foundation for the future than unifying the two.

@brson

brson commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

Heh, my feelings are mixed too. I think the current design is definitely a surprise, since it's uncommon, but compilers have bazillions of options, and keeping them organized is a noble goal.

My inclination is to stick with the status quo, and revisit later if it continues to be an issue.

I'll take the liberty of closing. Thanks @richo.

@brson brson closed this Mar 12, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 8, 2026
Distribute windows builts with mimalloc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants