Fix ICE for unexpected < in pattern#22544
Merged
Merged
Conversation
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
There was a problem hiding this comment.
hmm, I'm not actually sure we should accept this syntax in a pattern ...
Contributor
There was a problem hiding this comment.
(of course it could be that we're already accepting this syntax in a pattern. But nonetheless, I'm not sure I want to validate such acceptance in a formal test.)
Contributor
Author
There was a problem hiding this comment.
But current nightly accept it.
I was surprised too.
Contributor
There was a problem hiding this comment.
Well, lets bring up this up as a separate question to the team. (We have a triage meeting in 1.5 hours; I'll file a ticket for it.)
Contributor
|
@bombless r=me if you remove the aforementioned questionable run-pass test. |
Contributor
Author
Contributor
Author
|
r? @pnkfelix |
Contributor
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 23, 2015
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Jun 8, 2026
Rustc pull update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22426
I'm not sure which is better:
<"<, expect one of=>,:,("But this PR is actually mergable now