Add tests for expect ident but find enum or struct panic

[edwardw]

Closes #22589
Closes #22647
Closes #22665
Closes #22712

[rust-highfive]

r? @nick29581

(rust_highfive has picked a reviewer for you, use r? to override)

[nrc]

nit s/duo/due

[edwardw]

Done.

[nrc]

r+ with the typo fixed.

[nrc]

@bors r+ 2931c21

[Manishearth]

When running check-stage1 on this I get the following error:

/opt/rust/src/test/parse-fail/issue-22426.rs:18:16: 18:17 error: unexpected token: `<`
/opt/rust/src/test/parse-fail/issue-22426.rs:18             Foo<T>(ref x, ref y) => {}  //~ ERROR expected identifier, found enum or struct
                                                               ^

Should I expect this to only work for check-stage2?

[edwardw]

This is weird. This test in my local make check-stage1-pfail runs fine.

[Manishearth]

@bors: r-

I figured it out, #22544 broke your PR. Please rebase onto master and ask me for an r+ again (I'll try to include it into the rollup if there's time). Thanks!

[bors]

🙀 again is not a valid commit SHA. Please try again with 2931c21.

[bors]

⌛ Trying commit 2931c21 with merge 1f28313...

[Manishearth]

@bors: r-

[Manishearth]

dammit bors

[edwardw]

I'm looking into it right now, could be some in between commits caused behavior change of the parser. And building LLVM, it will take a while.

[Manishearth]

@edwardw No need to look for it, the change that broke this PR was #22544 :)

[edwardw]

@Manishearth yeah, but I still need to verify it locally first. Besides I have the feeling that my patch will reduce to just bunch of tests 🚴

[edwardw]

It is merely tests now.

r? @Manishearth

[Manishearth]

@bors r=nick29581 rollup

[bors]

🙀 rollup is not a valid commit SHA. Please try again with a1396d2.

[Manishearth]

@bors r=nick29581 a1396d2 rollup

[l0kod]

Not sure it's exactly the same, but crash Rust nightly from play.rust-lang.org as well:

use std::rc::Rc;

fn main() {
    match Rc::new(1) {
        Rc<_> => {}
    }
}

[edwardw]

@l0kod, playpen must've been a little bit lagged behind. Just run your code locally and rustc correctly bailed itself out:

use std::rc::Rc;

fn main() {
    match Rc::new(1) {
        Rc<_> => {}  // error: unexpected token: `<`
    }
}