Skip to content

Update the bootstrap compiler#37800

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:new-bootstrap
Nov 30, 2016
Merged

Update the bootstrap compiler#37800
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:new-bootstrap

Conversation

@alexcrichton

@alexcrichton alexcrichton commented Nov 16, 2016

Copy link
Copy Markdown
Member

Now that we've got a beta build, let's use it!

@alexcrichton alexcrichton force-pushed the new-bootstrap branch 3 times, most recently from 2f10b41 to 262e5d0 Compare November 17, 2016 00:06
@brson

brson commented Nov 17, 2016

Copy link
Copy Markdown
Contributor

This is still waiting on a beta that contains a cargo fix for rust-lang/cargo#3280. Next beta after rust-lang-deprecated/rust-packaging#66 should have it.

@brson

brson commented Nov 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Subsumes #37635

@alexcrichton

alexcrichton commented Nov 17, 2016

Copy link
Copy Markdown
Member Author

Updated the Cargo date, should be good to go

@xen0n xen0n mentioned this pull request Nov 17, 2016
Closed
@alexcrichton alexcrichton mentioned this pull request Nov 18, 2016
Closed
@bors

bors commented Nov 20, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37831) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Nov 21, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37127) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

alexcrichton commented Nov 22, 2016

Copy link
Copy Markdown
Member Author

r? @brson

@eddyb eddyb mentioned this pull request Nov 28, 2016
Closed
@bors

bors commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37965) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

alexcrichton commented Nov 30, 2016

Copy link
Copy Markdown
Member Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned brson Nov 30, 2016
eddyb
eddyb suggested changes Nov 30, 2016
View reviewed changes

@eddyb eddyb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comments addressed.

Comment thread src/librustc_llvm/lib.rs Outdated

@eddyb eddyb Nov 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't/shouldn't be removed - Travis failed on this.

Comment thread src/tools/compiletest/Cargo.toml Outdated

@eddyb eddyb Nov 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be preserved, or opt-level = 2 be removed otherwise at the top-level.

@alexcrichton
Update the bootstrap compiler
2186660 
Now that we've got a beta build, let's use it!
@alexcrichton

alexcrichton commented Nov 30, 2016

Copy link
Copy Markdown
Member Author

@bors: r=eddyb

@bors

bors commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 2186660 has been approved by eddyb

@bors

bors commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2186660 with merge ecff71a...

bors added a commit that referenced this pull request Nov 30, 2016
@bors
Auto merge of #37800 - alexcrichton:new-bootstrap, r=eddyb
ecff71a 
Update the bootstrap compiler

Now that we've got a beta build, let's use it!
@bors

bors commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing ecff71a to master...

@bors bors merged commit 2186660 into rust-lang:master Nov 30, 2016
This was referenced Nov 30, 2016
Closed
Merged
Merged
Merged
@alexcrichton alexcrichton mentioned this pull request Dec 1, 2016
Merged
@alexcrichton alexcrichton deleted the new-bootstrap branch December 19, 2016 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eddyb eddyb eddyb requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eddyb eddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcrichton @brson @bors @eddyb