Skip to content

Add 'platform-specific' section to sleep_ms to match sleep.#38761

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:thread-sleep-formatting
Jan 21, 2017
Merged

Add 'platform-specific' section to sleep_ms to match sleep.#38761
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:thread-sleep-formatting

Conversation

@frewsxcv

@frewsxcv frewsxcv commented Jan 1, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@retep998

retep998 commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

There is an equivalent thing on Windows, where the sleep won't return early due to an asynchronous procedure call because it isn't an alertable sleep.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Thanks @frewsxcv!

@bors

bors commented Jan 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 20fd6cc has been approved by alexcrichton

@alexcrichton alexcrichton self-assigned this Jan 19, 2017
@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 19, 2017
@bors

bors commented Jan 19, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 20fd6cc with merge f8779b6...

bors added a commit that referenced this pull request Jan 19, 2017
Add 'platform-specific' section to `sleep_ms` to match `sleep`.

None
@bors

bors commented Jan 19, 2017

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

Presumably some bug in @bors? The builds both completed sucessfully: https://travis-ci.org/rust-lang/rust/builds/193285888 and https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1606.

@bors

bors commented Jan 20, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 20fd6cc with merge 435118e...

@frewsxcv

Copy link
Copy Markdown
Contributor Author

@bors rollup

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

  • interrupting to bump the rollup up

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2017
…=alexcrichton

Add 'platform-specific' section to `sleep_ms` to match `sleep`.

None
bors added a commit that referenced this pull request Jan 20, 2017
bors added a commit that referenced this pull request Jan 21, 2017
@bors bors merged commit 20fd6cc into rust-lang:master Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants