Skip to content

[beta] Backport union stabilization PRs#42328

Closed
petrochenkov wants to merge 4 commits into
rust-lang:betafrom
petrochenkov:beta
Closed

[beta] Backport union stabilization PRs#42328
petrochenkov wants to merge 4 commits into
rust-lang:betafrom
petrochenkov:beta

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

@rust-highfive

Copy link
Copy Markdown
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@est31

est31 commented May 31, 2017

Copy link
Copy Markdown
Member

I think this should be put into the release notes, no?

@brson

brson commented May 31, 2017

Copy link
Copy Markdown
Contributor

I'm going to update the relnotes and backport as part of this pr.

@brson

brson commented May 31, 2017

Copy link
Copy Markdown
Contributor

This isn't backporting the reference docs, and it probably should.

@brson

brson commented May 31, 2017

Copy link
Copy Markdown
Contributor

There's no beta branch of the reference to backport the reference docs to.

I'm feeling a bit uncomfortable about this.

@nikomatsakis

Copy link
Copy Markdown
Contributor

I'll copy my comment from #42068:

"I don't strongly object, but I'm surprised we would backport this. I feel like we try to keep backports to regressions or important bug fixes, and only rarely backport stabilizations -- the exception would be if some feature is hotly demanded. But otoh this seems pretty darn low risk, so no real objection."

@brson

brson commented May 31, 2017

Copy link
Copy Markdown
Contributor

I'm going to look into backporting the reference directly from reference/master and see if it makes sense on beta.

@brson

brson commented May 31, 2017

Copy link
Copy Markdown
Contributor

Here's the reference diff: rust-lang/reference@6b0de90...master

@brson

brson commented May 31, 2017

Copy link
Copy Markdown
Contributor

Let's not do it. Feels risky to me.

@brson brson closed this May 31, 2017
@lilianmoraru

Copy link
Copy Markdown

So, this did not land?
The release notes say that it landed: https://github.com/rust-lang/rust/pull/42503/files#diff-5cafcf46bfb947f8e58fa5c16d39018cR13

@petrochenkov petrochenkov deleted the beta branch August 26, 2017 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants