From 81ea94f2ff8ce6cfb6c3a81cc68fc79463913b2e Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Mon, 15 Jun 2026 10:56:46 -0400 Subject: [PATCH 1/4] Add intrinsics support on Linux on Power for vec_add(vector_double, vector_double). --- crates/core_arch/src/powerpc/altivec.rs | 2 +- crates/core_arch/src/powerpc/vsx.rs | 33 +++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/crates/core_arch/src/powerpc/altivec.rs b/crates/core_arch/src/powerpc/altivec.rs index ccfed88a93..9e8af48fa6 100644 --- a/crates/core_arch/src/powerpc/altivec.rs +++ b/crates/core_arch/src/powerpc/altivec.rs @@ -411,7 +411,7 @@ unsafe extern "unadjusted" { } #[macro_use] -mod sealed { +pub(crate) mod sealed { use super::*; #[unstable(feature = "stdarch_powerpc", issue = "111145")] diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index 60cb2ad44c..7b648cbb7b 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -10,6 +10,7 @@ use crate::core_arch::powerpc::*; use crate::core_arch::simd::*; +use crate::intrinsics::simd::simd_add; #[cfg(test)] use stdarch_test::assert_instr; @@ -171,6 +172,27 @@ mod sealed { vec_mergeeo! { vector_unsigned_int, mergee, mergeo } vec_mergeeo! { vector_bool_int, mergee, mergeo } vec_mergeeo! { vector_float, mergee, mergeo } + + #[inline] + #[target_feature(enable = "vsx")] + #[cfg_attr(test, assert_instr(xvadddp))] + pub(crate) unsafe fn vec_add_double_double( + a: vector_double, + b: vector_double, + ) -> vector_double { + simd_add(a, b) + } +} + +// Implement AltiVec's VectorAdd trait for vector_double to enable vec_add support +#[unstable(feature = "stdarch_powerpc", issue = "111145")] +impl crate::core_arch::powerpc::altivec::sealed::VectorAdd for vector_double { + type Result = vector_double; + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_add(self, other: vector_double) -> Self::Result { + sealed::vec_add_double_double(self, other) + } } /// Vector permute. @@ -255,4 +277,15 @@ mod tests { test_vec_xxpermdi! {test_vec_xxpermdi_i64x2, i64x2, vector_signed_long, [0], [-1], [2], [-3]} test_vec_xxpermdi! {test_vec_xxpermdi_m64x2, m64x2, vector_bool_long, [false], [true], [false], [true]} test_vec_xxpermdi! {test_vec_xxpermdi_f64x2, f64x2, vector_double, [0.0], [1.0], [2.0], [3.0]} + + #[simd_test(enable = "vsx")] + fn test_vec_add_f64x2_f64x2() { + let a = vector_double::from(f64x2::from_array([1.0, 2.0])); + let b = vector_double::from(f64x2::from_array([3.0, 4.0])); + let expected = vector_double::from(f64x2::from_array([4.0, 6.0])); + + unsafe { + assert_eq!(f64x2::from(vec_add(a, b)), f64x2::from(expected)); + } + } } From 1dc3a44bb7b7af1af5ca910a3afd700e1e543c7a Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Wed, 17 Jun 2026 13:58:56 -0400 Subject: [PATCH 2/4] powerpc/vsx: implement vec_sub for vector_double --- crates/core_arch/src/powerpc/vsx.rs | 33 ++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index 7b648cbb7b..5b59e554e9 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -10,7 +10,7 @@ use crate::core_arch::powerpc::*; use crate::core_arch::simd::*; -use crate::intrinsics::simd::simd_add; +use crate::intrinsics::simd::{simd_add, simd_sub}; #[cfg(test)] use stdarch_test::assert_instr; @@ -182,6 +182,16 @@ mod sealed { ) -> vector_double { simd_add(a, b) } + + #[inline] + #[target_feature(enable = "vsx")] + #[cfg_attr(test, assert_instr(xvsubdp))] + pub(crate) unsafe fn vec_sub_double_double( + a: vector_double, + b: vector_double, + ) -> vector_double { + simd_sub(a, b) + } } // Implement AltiVec's VectorAdd trait for vector_double to enable vec_add support @@ -195,6 +205,17 @@ impl crate::core_arch::powerpc::altivec::sealed::VectorAdd for ve } } +// Implement AltiVec's VectorSub trait for vector_double to enable vec_sub support +#[unstable(feature = "stdarch_powerpc", issue = "111145")] +impl crate::core_arch::powerpc::altivec::sealed::VectorSub for vector_double { + type Result = vector_double; + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_sub(self, other: vector_double) -> Self::Result { + sealed::vec_sub_double_double(self, other) + } +} + /// Vector permute. #[inline] #[target_feature(enable = "vsx")] @@ -288,4 +309,14 @@ mod tests { assert_eq!(f64x2::from(vec_add(a, b)), f64x2::from(expected)); } } + #[simd_test(enable = "vsx")] + fn test_vec_sub_f64x2_f64x2() { + let a = vector_double::from(f64x2::from_array([5.0, 8.0])); + let b = vector_double::from(f64x2::from_array([3.0, 4.0])); + let expected = vector_double::from(f64x2::from_array([2.0, 4.0])); + + unsafe { + assert_eq!(f64x2::from(vec_sub(a, b)), f64x2::from(expected)); + } + } } From 78107a2feb81905c8dbb0b516cb51d8a308669a9 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Wed, 17 Jun 2026 14:08:23 -0400 Subject: [PATCH 3/4] powerpc/vsx: implement vec_mul for vector_double --- crates/core_arch/src/powerpc/vsx.rs | 33 ++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index 5b59e554e9..931af78526 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -10,7 +10,7 @@ use crate::core_arch::powerpc::*; use crate::core_arch::simd::*; -use crate::intrinsics::simd::{simd_add, simd_sub}; +use crate::intrinsics::simd::{simd_add, simd_mul, simd_sub}; #[cfg(test)] use stdarch_test::assert_instr; @@ -192,6 +192,16 @@ mod sealed { ) -> vector_double { simd_sub(a, b) } + + #[inline] + #[target_feature(enable = "vsx")] + #[cfg_attr(test, assert_instr(xvmuldp))] + pub(crate) unsafe fn vec_mul_double_double( + a: vector_double, + b: vector_double, + ) -> vector_double { + simd_mul(a, b) + } } // Implement AltiVec's VectorAdd trait for vector_double to enable vec_add support @@ -216,6 +226,16 @@ impl crate::core_arch::powerpc::altivec::sealed::VectorSub for ve } } +// Implement AltiVec's VectorMul trait for vector_double to enable vec_mul support. +#[unstable(feature = "stdarch_powerpc", issue = "111145")] +impl crate::core_arch::powerpc::altivec::sealed::VectorMul for vector_double { + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_mul(self, b: Self) -> Self { + sealed::vec_mul_double_double(self, b) + } +} + /// Vector permute. #[inline] #[target_feature(enable = "vsx")] @@ -319,4 +339,15 @@ mod tests { assert_eq!(f64x2::from(vec_sub(a, b)), f64x2::from(expected)); } } + + #[simd_test(enable = "vsx")] + fn test_vec_mul_f64x2_f64x2() { + let a = vector_double::from(f64x2::from_array([2.0, 3.0])); + let b = vector_double::from(f64x2::from_array([4.0, 5.0])); + let expected = vector_double::from(f64x2::from_array([8.0, 15.0])); + + unsafe { + assert_eq!(f64x2::from(vec_mul(a, b)), f64x2::from(expected)); + } + } } From 5f78ed1778a84c7dd1a9a183913d92b293eb9c2c Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 19 Jun 2026 08:21:55 -0400 Subject: [PATCH 4/4] fix bug --- crates/core_arch/src/powerpc/altivec.rs | 4 +- crates/core_arch/src/powerpc/vsx.rs | 60 ++++++++++++------------- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/crates/core_arch/src/powerpc/altivec.rs b/crates/core_arch/src/powerpc/altivec.rs index 9e8af48fa6..781de597a3 100644 --- a/crates/core_arch/src/powerpc/altivec.rs +++ b/crates/core_arch/src/powerpc/altivec.rs @@ -837,7 +837,6 @@ pub(crate) mod sealed { impl_vec_cmp! { [VectorCmpGt vec_cmpgt] ( vec_vcmpgtub, vec_vcmpgtsb, vec_vcmpgtuh, vec_vcmpgtsh, vec_vcmpgtuw, vec_vcmpgtsw ) } test_impl! { vec_vcmpgefp(a: vector_float, b: vector_float) -> vector_bool_int [ vcmpgefp, vcmpgefp ] } - test_impl! { vec_vcmpequb(a: vector_unsigned_char, b: vector_unsigned_char) -> vector_bool_char [ vcmpequb, vcmpequb ] } test_impl! { vec_vcmpequh(a: vector_unsigned_short, b: vector_unsigned_short) -> vector_bool_short [ vcmpequh, vcmpequh ] } test_impl! { vec_vcmpequw(a: vector_unsigned_int, b: vector_unsigned_int) -> vector_bool_int [ vcmpequw, vcmpequw ] } @@ -2416,7 +2415,8 @@ pub(crate) mod sealed { #[inline] #[target_feature(enable = "altivec")] - #[cfg_attr(test, assert_instr(xvaddsp))] + #[cfg_attr(all(test, not(target_feature = "vsx")), assert_instr(vaddfp))] + #[cfg_attr(all(test, target_feature = "vsx"), assert_instr(xvaddsp))] pub unsafe fn vec_add_float_float(a: vector_float, b: vector_float) -> vector_float { simd_add(a, b) } diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index 931af78526..efa316c6e9 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -183,6 +183,17 @@ mod sealed { simd_add(a, b) } + // Implement AltiVec's VectorAdd trait for vector_double to enable vec_add support + #[unstable(feature = "stdarch_powerpc", issue = "111145")] + impl crate::core_arch::powerpc::altivec::sealed::VectorAdd for vector_double { + type Result = vector_double; + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_add(self, other: vector_double) -> Self::Result { + vec_add_double_double(self, other) + } + } + #[inline] #[target_feature(enable = "vsx")] #[cfg_attr(test, assert_instr(xvsubdp))] @@ -193,6 +204,17 @@ mod sealed { simd_sub(a, b) } + // Implement AltiVec's VectorSub trait for vector_double to enable vec_sub support + #[unstable(feature = "stdarch_powerpc", issue = "111145")] + impl crate::core_arch::powerpc::altivec::sealed::VectorSub for vector_double { + type Result = vector_double; + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_sub(self, other: vector_double) -> Self::Result { + vec_sub_double_double(self, other) + } + } + #[inline] #[target_feature(enable = "vsx")] #[cfg_attr(test, assert_instr(xvmuldp))] @@ -202,37 +224,15 @@ mod sealed { ) -> vector_double { simd_mul(a, b) } -} - -// Implement AltiVec's VectorAdd trait for vector_double to enable vec_add support -#[unstable(feature = "stdarch_powerpc", issue = "111145")] -impl crate::core_arch::powerpc::altivec::sealed::VectorAdd for vector_double { - type Result = vector_double; - #[inline] - #[target_feature(enable = "vsx")] - unsafe fn vec_add(self, other: vector_double) -> Self::Result { - sealed::vec_add_double_double(self, other) - } -} -// Implement AltiVec's VectorSub trait for vector_double to enable vec_sub support -#[unstable(feature = "stdarch_powerpc", issue = "111145")] -impl crate::core_arch::powerpc::altivec::sealed::VectorSub for vector_double { - type Result = vector_double; - #[inline] - #[target_feature(enable = "vsx")] - unsafe fn vec_sub(self, other: vector_double) -> Self::Result { - sealed::vec_sub_double_double(self, other) - } -} - -// Implement AltiVec's VectorMul trait for vector_double to enable vec_mul support. -#[unstable(feature = "stdarch_powerpc", issue = "111145")] -impl crate::core_arch::powerpc::altivec::sealed::VectorMul for vector_double { - #[inline] - #[target_feature(enable = "vsx")] - unsafe fn vec_mul(self, b: Self) -> Self { - sealed::vec_mul_double_double(self, b) + // Implement AltiVec's VectorMul trait for vector_double to enable vec_mul support. + #[unstable(feature = "stdarch_powerpc", issue = "111145")] + impl crate::core_arch::powerpc::altivec::sealed::VectorMul for vector_double { + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_mul(self, b: Self) -> Self { + vec_mul_double_double(self, b) + } } }