implement FromIterator for ArrayBase<S,Ix1>

Author: max-sixty

src/impl_constructors.rs

@@ -52,22 +52,6 @@ where
         unsafe { Self::from_shape_vec_unchecked(v.len() as Ix, v) }
     }
 
-    /// Create a one-dimensional array from an iterable.
-    ///
-    /// **Panics** if the length is greater than `isize::MAX`.
-    ///
-    /// ```rust
-    /// use ndarray::{Array, arr1};
-    ///
-    /// let array = Array::from_iter((0..5).map(|x| x * x));
-    /// assert!(array == arr1(&[0, 1, 4, 9, 16]))
-    /// ```
-    pub fn from_iter<I>(iterable: I) -> Self
-    where
-        I: IntoIterator<Item = A>,
-    {
-        Self::from_vec(iterable.into_iter().collect())
-    }
 
     /// Create a one-dimensional array with `n` evenly spaced elements from
     /// `start` to `end` (inclusive). `A` must be a floating point type.
@@ -174,6 +158,28 @@ where
     }
 }
 
+impl<S,A> std::iter::FromIterator<A> for ArrayBase<S,Ix1> 
+where
+    S: DataOwned<Elem = A>,
+{
+    /// Create a one-dimensional array from an iterable.
+    ///
+    /// **Panics** if the length is greater than `isize::MAX`.
+    ///
+    /// ```rust
+    /// use ndarray::{Array, arr1};
+    ///
+    /// let array = Array::from_iter((0..5).map(|x| x * x));
+    /// assert!(array == arr1(&[0, 1, 4, 9, 16]))
+    /// ```
+    fn from_iter<I>(iterable: I) -> Self
+    where
+        I: IntoIterator<Item = A>,
+    {
+        Self::from_vec(iterable.into_iter().collect())
+    }
+}
+
 /// ## Constructor methods for two-dimensional arrays.
 impl<S, A> ArrayBase<S, Ix2>
 where
@@ -327,7 +333,7 @@ where
             unsafe { Self::from_shape_vec_unchecked(shape, v) }
         } else {
             let dim = shape.dim.clone();
-            let v = to_vec_mapped(indexes::indices_iter_f(dim).into_iter(), f);
+            let v = to_vec_mapped(indexes::indices_iter_f(dim), f);
             unsafe { Self::from_shape_vec_unchecked(shape, v) }
         }
     }
@@ -422,8 +428,8 @@ where
         ArrayBase {
             ptr: v.as_mut_ptr(),
             data: DataOwned::new(v),
-           strides,
-           dim,
+            strides,
+            dim,
         }
     }