fix: use Events.ClientReady instead of deprecated 'ready' event

Discord.js v14 renamed the 'ready' event to 'clientReady' and it will
only emit under that name in v15. Using the Events.ClientReady enum
provides type safety and forward compatibility.

- Update src/index.ts to import and use Events.ClientReady
- Update src/platforms/discord.ts to import and use Events.ClientReady
- Update test mock to export Events and check for Events.ClientReady

Author: ryanio

src/index.ts

@@ -1,4 +1,4 @@
-import { Client, type TextBasedChannel } from "discord.js";
+import { Client, Events, type TextBasedChannel } from "discord.js";
 import {
   type EventTimestampSource,
   fetchCollectionSlug,
@@ -31,7 +31,7 @@ const fetchDiscordChannelNames = async (): Promise<Map<string, string>> => {
 
   try {
     await new Promise<void>((resolve) => {
-      client.on("ready", () => resolve());
+      client.on(Events.ClientReady, () => resolve());
       client.login(process.env.DISCORD_TOKEN);
     });
 

src/platforms/discord.ts

@@ -2,6 +2,7 @@ import {
   Client,
   type ColorResolvable,
   EmbedBuilder,
+  Events,
   type MessageCreateOptions,
   type TextBasedChannel,
 } from "discord.js";
@@ -410,7 +411,7 @@ const messagesForEvents = async (
 
 const login = (client: Client): Promise<void> =>
   new Promise<void>((resolve) => {
-    client.on("ready", () => {
+    client.on(Events.ClientReady, () => {
       resolve();
     });
     client.login(process.env.DISCORD_TOKEN);

test/platforms/discord.test.ts

@@ -8,10 +8,11 @@ const channelsMap: Record<string, { send: jest.Mock; id: string }> = {};
 const setColorArgs: Record<string, string[]> = {};
 
 jest.mock("discord.js", () => {
+  const Events = { ClientReady: "clientReady" };
   const Client = jest.fn().mockImplementation(() => {
     return {
       on: (event: string, cb: () => void) => {
-        if (event === "ready") {
+        if (event === Events.ClientReady) {
           // Call immediately instead of using setImmediate for faster tests
           cb();
         }
@@ -42,7 +43,7 @@ jest.mock("discord.js", () => {
     };
     return obj;
   });
-  return { Client, EmbedBuilder };
+  return { Client, EmbedBuilder, Events };
 });
 
 // Mock opensea username