Make Device.sensors() only return read-only descriptors (#1871)

rytilahti · web-flow · commit 36b402505091 · 2023-12-05T01:32:15.000+01:00
This was incorrectly returning also readable settings, this changes the
behavior to conform with the docstring.
diff --git a/miio/device.py b/miio/device.py
@@ -299,7 +299,7 @@ def sensors(self) -> DescriptorCollection[PropertyDescriptor]:
             {
                 k: v
                 for k, v in self.descriptors().items()
-                if isinstance(v, PropertyDescriptor) and v.access & AccessFlags.Read
+                if v.access == AccessFlags.Read
             },
             device=self,
         )

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ def sensors(self) -> DescriptorCollection[PropertyDescriptor]:`
`299`	`299`	`{`
`300`	`300`	`k: v`
`301`	`301`	`for k, v in self.descriptors().items()`
`302`		`- if isinstance(v, PropertyDescriptor) and v.access & AccessFlags.Read`
	`302`	`+ if v.access == AccessFlags.Read`
`303`	`303`	`},`
`304`	`304`	`device=self,`
`305`	`305`	`)`