Skip to content

Commit 3b4c992

Browse files
authored
Remove OR operator from the benchmark job (#736)
This PR: - Fix the benchmark CI job to prebent regressions like #735. It is fixed by removing the OR operator because if a benchmark failed, it only outputted a message but didn't return a non-zero exit code. - Also bumps the `0.8.x` compiler version to the latest one (0.8.24)
1 parent 3da1415 commit 3b4c992

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ jobs:
6868
strategy:
6969
fail-fast: false
7070
matrix:
71-
solidity: ["0.7.6", "0.8.19"]
71+
solidity: ["0.7.6", "0.8.24"]
7272
include:
73-
- solidity: "0.8.19"
73+
- solidity: "0.8.24"
7474
settings: '{"viaIR":true,"optimizer":{"enabled":true,"runs":1000000}}'
7575
env:
7676
SOLIDITY_VERSION: ${{ matrix.solidity }}
@@ -81,4 +81,4 @@ jobs:
8181
with:
8282
node-version: ${{ env.NODE_VERSION }}
8383
cache: "npm"
84-
- run: (npm ci && npm run build && npx hardhat codesize --contractname Safe && npm run benchmark) || echo "Benchmark failed"
84+
- run: npm ci && npm run build && npx hardhat codesize --contractname Safe && npm run benchmark

0 commit comments

Comments
 (0)