Merged
Conversation
akshay-ap
changed the title
akshay-ap
force-pushed
the
test-checknsigs
branch
2 times, most recently
from
78d30b1 to
10eeeee
Compare
mmv08
force-pushed
the
release/v1.5.0
branch
3 times, most recently
from
1ba4f55 to
04403af
Compare
Contributor
|
Can this be closed? |
Contributor
Author
yes |
mmv08
changed the title
checkNSignatures
…into test-checknsigs
mmv08
requested review from
a team,
Uxio0,
mmv08 and
rmeissner
and removed request for
a team
mmv08
reviewed
Jul 18, 2023
…contracts into test-checknsigs
mmv08
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Please pay attention to the test cases, we need to ensure that this thing is properly tested