Extracting method to ease future switching logic

In discussion with @no_reply, in addressing #4195, we want to explore
the following path:

1) As early as possible in the request cycle, create a
   Hyrax::UploadedFile for both a CarrierWave file or a file selected
   for upload by BrowseEverything.
2) Building on step 1, we would then hope to reduce branching logic in the
   request cycle, and preserve existing class interfaces.

By making this non-breaking change, I'm orienting the code to deliver on
this aspirational goal.

Next steps would be:

1) Update the Hyrax::WorksControllerBehavior to create
   Hyrax::UploadedFile records for the files selected from
   BrowseEverything (note CarrierWave handles the "inline" uploads).
2) Adjust the extracted `Hyrax::UploadedFile#perform_ingest_later`
   method to handle files that were created from BrowseEverything.

The plan is to add a field to the UploadedFile (perhaps
`url_of_file_to_ingest`) that the Hyrax::WorksControllerBehavior would
populate based on user input parameters.

With that in place, we could look at backporting the solution into the
ActorStack.

Author: jeremyf

app/models/hyrax/uploaded_file.rb

@@ -28,5 +28,26 @@ def add_file_set!(file_set)
             end
       update!(file_set_uri: uri)
     end
+
+    ##
+    # Schedule an IngestJob for this file and the given file_set.
+    #
+    # @note This was extracted from the Hyrax::WorkUploadsHandler
+    #       class.  The aspirational goal is a multi-step consideration:
+    #
+    # - Reduce branching logic in the controller
+    # - Reduce duplication of transaction steps
+    #
+    # @note This may only be applicable for a Valkyrie resource
+    #
+    # @todo Refactor to handle both an uploaded_file (current
+    #       behavior) and handle a file assigned via BrowseEverything.
+    #
+    # @param file_set [FileSet]
+    # @return [void]
+    def perform_ingest_later(file_set:)
+      wrapper = JobIoWrapper.create_with_varied_file_handling!(user: user, file: self, relation: :original_file, file_set: file_set)
+      IngestJob.perform_later(wrapper)
+    end
   end
 end

app/services/hyrax/work_uploads_handler.rb

@@ -114,8 +114,9 @@ def make_file_set_and_ingest(file)
       file_set.permission_manager.acl.save if file_set.permission_manager.acl.pending_changes?
       append_to_work(file_set)
 
-      IngestJob.perform_later(wrap_file(file, file_set))
+      file.perform_ingest_later(file_set: file_set)
       Hyrax.publisher.publish('object.metadata.updated', object: file_set, user: file.user)
+
       { file_set: file_set, user: file.user }
     end
 
@@ -160,13 +161,6 @@ def target_permissions
       @target_permissions ||= Hyrax::AccessControlList.new(resource: work)
     end
 
-    ##
-    # @api private
-    # @return [JobIoWrapper]
-    def wrap_file(file, file_set)
-      JobIoWrapper.create_with_varied_file_handling!(user: file.user, file: file, relation: :original_file, file_set: file_set)
-    end
-
     ##
     # @api private
     #

spec/models/hyrax/uploaded_file_spec.rb

@@ -8,4 +8,16 @@
     temp_dir = Rails.root + 'tmp'
     expect(subject.file.path).to start_with temp_dir.to_s
   end
+
+  describe '#perform_ingest_later' do
+    let(:user) { FactoryBot.create(:user) }
+    subject { described_class.create(file: file1, user: user) }
+    context 'for a Valkyrie object' do
+      it "schedules an IngestJob" do
+        file_set = FactoryBot.valkyrie_create(:hyrax_file_set)
+        expect(IngestJob).to receive(:perform_later).with(kind_of(JobIoWrapper))
+        subject.perform_ingest_later(file_set: file_set)
+      end
+    end
+  end
 end