Fix deprecated calls to Command::cargo_bin (#409)

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>

Author: sarroutbi

tests/koji-retriever-test.rs

@@ -24,26 +24,25 @@ use assert_cmd::prelude::*; // Add methods on commands
 use predicates::prelude::*; // Used for writing assertions
 use std::process::Command; // Run programs
 
-const KOJI_RETRIEVER_BINARY: &str = "koji-retriever";
 const LS_CMD: &str = "/usr/bin/ls";
 const RM_CMD: &str = "/usr/bin/rm";
 
 #[test]
 fn url_existing_file_does_not_exist_in_test_mode_test() -> Result<(), Box<dyn std::error::Error>> {
     // Clean previous downloads (if any)
-    let mut rm_cmd = Command::cargo_bin(RM_CMD)?;
+    let mut rm_cmd = Command::new(RM_CMD);
     rm_cmd
         .arg("-v")
         .arg("-f")
         .arg("/tmp/pykickstart-3.47-1.fc38.src.rpm");
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u")
         .arg("https://koji.fedoraproject.org/koji/buildinfo?buildID=2171737")
         .arg("-d")
         .arg("/tmp")
         .arg("-t");
     cmd.assert().success();
-    let mut cmd_ls = Command::cargo_bin(LS_CMD)?;
+    let mut cmd_ls = Command::new(LS_CMD);
     cmd_ls.arg("/tmp/pykickstart-3.47-1.fc38.src.rpm");
     cmd_ls
         .assert()
@@ -54,7 +53,7 @@ fn url_existing_file_does_not_exist_in_test_mode_test() -> Result<(), Box<dyn st
 
 #[test]
 fn url_existing_test() -> Result<(), Box<dyn std::error::Error>> {
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u")
         .arg("https://koji.fedoraproject.org/koji/buildinfo?buildID=2249970")
         .arg("-d")
@@ -67,15 +66,15 @@ fn url_existing_test() -> Result<(), Box<dyn std::error::Error>> {
 
 #[test]
 fn url_does_not_exist_test() -> Result<(), Box<dyn std::error::Error>> {
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u").arg("https://unexisting-url.almost.sure");
     cmd.assert().failure();
     Ok(())
 }
 
 #[test]
 fn url_existing_verbose_test() -> Result<(), Box<dyn std::error::Error>> {
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u")
         .arg("https://koji.fedoraproject.org/koji/buildinfo?buildID=2249970")
         .arg("-v")
@@ -94,7 +93,7 @@ fn url_existing_verbose_test() -> Result<(), Box<dyn std::error::Error>> {
 
 #[test]
 fn url_existing_test_mode_verbose_test() -> Result<(), Box<dyn std::error::Error>> {
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u")
         .arg("https://koji.fedoraproject.org/koji/buildinfo?buildID=2249970")
         .arg("-v")
@@ -117,7 +116,7 @@ fn url_existing_test_mode_verbose_test() -> Result<(), Box<dyn std::error::Error
 
 #[test]
 fn url_existing_slash_end_directory_test() -> Result<(), Box<dyn std::error::Error>> {
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u")
         .arg("https://koji.fedoraproject.org/koji/buildinfo?buildID=2249970")
         .arg("-v")
@@ -131,7 +130,7 @@ fn url_existing_slash_end_directory_test() -> Result<(), Box<dyn std::error::Err
 
 #[test]
 fn url_existing_files_exist_test() -> Result<(), Box<dyn std::error::Error>> {
-    let mut cmd = Command::cargo_bin(KOJI_RETRIEVER_BINARY)?;
+    let mut cmd = Command::new(assert_cmd::cargo::cargo_bin!("koji-retriever"));
     cmd.arg("-u")
         .arg("https://koji.fedoraproject.org/koji/buildinfo?buildID=2249970")
         .arg("-d")
@@ -140,17 +139,17 @@ fn url_existing_files_exist_test() -> Result<(), Box<dyn std::error::Error>> {
     cmd.assert().success().stdout(predicate::str::contains(
         "/tmp/pykickstart-3.48-3.fc39.src.rpm",
     ));
-    let mut cmd_ls = Command::cargo_bin(LS_CMD)?;
+    let mut cmd_ls = Command::new(LS_CMD);
     cmd_ls.arg("/tmp/pykickstart-3.48-3.fc39.src.rpm");
     cmd.assert().success().stdout(predicate::str::contains(
         "/tmp/pykickstart-3.48-3.fc39.src.rpm",
     ));
-    cmd_ls = Command::cargo_bin(LS_CMD)?;
+    cmd_ls = Command::new(LS_CMD);
     cmd_ls.arg("/tmp/pykickstart-3.48-3.fc39.noarch.rpm");
     cmd.assert().success().stdout(predicate::str::contains(
         "/tmp/pykickstart-3.48-3.fc39.noarch.rpm",
     ));
-    cmd_ls = Command::cargo_bin(LS_CMD)?;
+    cmd_ls = Command::new(LS_CMD);
     cmd_ls.arg("/tmp/python3-kickstart-3.48-3.fc39.noarch.rpm");
     cmd.assert().success().stdout(predicate::str::contains(
         "/tmp/python3-kickstart-3.48-3.fc39.noarch.rpm",