-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade webpack from 1.15.0 to 2.2.0 #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…g/webpack/prod/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades webpack from version 1.x to 2.x to resolve a security vulnerability. This is a major version upgrade and introduces breaking changes. The Webpack configuration for the webpack-prod-fixture is incompatible with Webpack 2, which will cause the build for this fixture to fail. I have added a critical review comment on the package.json file detailing the necessary changes to the Webpack configuration to make it compatible with version 2.
| "name": "webpack-prod-fixture", | ||
| "dependencies": { | ||
| "webpack": "^1.14.0" | ||
| "webpack": "^2.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to Webpack v2 is a major version bump and introduces breaking changes that will cause the build for this fixture to fail.
The Webpack configuration in fixtures/packaging/webpack/prod/config.js uses resolve.root, which was removed in Webpack 2. The build will fail with an error like Configuration validation failed: ... configuration.resolve has an unknown property 'root' ....
To fix this, you'll need to update config.js to use resolve.modules instead. For example:
// In fixtures/packaging/webpack/prod/config.js
// ...
resolve: {
modules: [
path.resolve('../../../../build/node_modules/'),
'node_modules'
]
},
// ...Without this change, the build script for this fixture will fail, breaking the associated tests.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
fixtures/packaging/webpack/prod/package.jsonfixtures/packaging/webpack/prod/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.