Skip to content

[Snyk] Security upgrade webpack from 1.15.0 to 2.2.0 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabharch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade webpack from 1.15.0 to 2.2.0 #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/packaging/webpack/prod/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": true,
"name": "webpack-prod-fixture",
"dependencies": {
"webpack": "^1.14.0"
"webpack": "^2.2.0"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to Webpack v2 is a major version bump and introduces breaking changes that will cause the build for this fixture to fail.

The Webpack configuration in fixtures/packaging/webpack/prod/config.js uses resolve.root, which was removed in Webpack 2. The build will fail with an error like Configuration validation failed: ... configuration.resolve has an unknown property 'root' ....

To fix this, you'll need to update config.js to use resolve.modules instead. For example:

// In fixtures/packaging/webpack/prod/config.js
// ...
  resolve: {
    modules: [
      path.resolve('../../../../build/node_modules/'),
      'node_modules'
    ]
  },
// ...

Without this change, the build script for this fixture will fail, breaking the associated tests.

},
"scripts": {
"build": "rm -f output.js && webpack --config config.js"
Expand Down
Loading