From 332f506a2596b434a1f49d6d91399227b8a4d5a4 Mon Sep 17 00:00:00 2001 From: Jarrod Millman Date: Sat, 11 Mar 2023 20:50:03 -0800 Subject: [PATCH] Update tests to improve coverage --- .github/workflows/coverage.yml | 4 +++- lazy_loader/tests/test_lazy_loader.py | 12 +++--------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 234dc54..4f85d2e 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -8,7 +8,7 @@ on: jobs: report: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest strategy: matrix: python-version: ["3.10"] @@ -23,6 +23,8 @@ jobs: run: | python -m pip install --upgrade pip wheel setuptools python -m pip install ".[test]" + python -m pip install --upgrade numpy + python -m pip uninstall --yes scipy pip list - name: Measure test coverage diff --git a/lazy_loader/tests/test_lazy_loader.py b/lazy_loader/tests/test_lazy_loader.py index 800502a..1c8dbd3 100644 --- a/lazy_loader/tests/test_lazy_loader.py +++ b/lazy_loader/tests/test_lazy_loader.py @@ -49,22 +49,16 @@ def test_lazy_import_impact_on_sys_modules(): def test_lazy_import_nonbuiltins(): - sp = lazy.load("scipy") np = lazy.load("numpy") + sp = lazy.load("scipy") + if not isinstance(np, lazy.DelayedImportErrorModule): + assert np.sin(np.pi) == pytest.approx(0, 1e-6) if isinstance(sp, lazy.DelayedImportErrorModule): try: sp.pi assert False except ModuleNotFoundError: pass - elif isinstance(np, lazy.DelayedImportErrorModule): - try: - np.sin(np.pi) - assert False - except ModuleNotFoundError: - pass - else: - assert np.sin(sp.pi) == pytest.approx(0, 1e-6) def test_lazy_attach():