Skip to content

Commit 9a8a3ab

Browse files
authored
fix yml checking (#331)
1 parent f80c4da commit 9a8a3ab

File tree

3 files changed

+17
-20
lines changed

3 files changed

+17
-20
lines changed

.github/workflows/testing.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
steps:
2626

2727
# Install skada
28-
- name: Checking Out Repository
28+
- name: Checking Out Repository # yamllint disable-line rule:indentation
2929
uses: actions/checkout@v4
3030
# Cache 'skada' datasets
3131
- name: Create/Restore Skada Data Cache
@@ -46,7 +46,6 @@ jobs:
4646
pre-commit run --all-files
4747
4848
49-
5049
Test-minimal:
5150
runs-on: ubuntu-latest
5251
strategy:
@@ -57,7 +56,7 @@ jobs:
5756
steps:
5857

5958
# Install skada
60-
- name: Checking Out Repository
59+
- name: Checking Out Repository # yamllint disable-line rule:indentation
6160
uses: actions/checkout@v4
6261
# Cache 'skada' datasets
6362
- name: Create/Restore Skada Data Cache
@@ -98,7 +97,7 @@ jobs:
9897
steps:
9998

10099
# Install skada
101-
- name: Checking Out Repository
100+
- name: Checking Out Repository # yamllint disable-line rule:indentation
102101
uses: actions/checkout@v4
103102
# Cache 'skada' datasets
104103
- name: Create/Restore Skada Data Cache
@@ -125,4 +124,4 @@ jobs:
125124
env:
126125
token: ${{ secrets.CODECOV_TOKEN }}
127126
verbose: true
128-
fail_ci_if_error: true
127+
fail_ci_if_error: true

.yamllint.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
extends: default
22

33
ignore: |
4-
.github/workflows/testing.yml
54
.circleci/config.yml
6-
codecov.yml
75
86
rules:
97
line-length: disable

codecov.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
codecov:
66
bot: "codecov-io"
77
strict_yaml_branch: "yaml-config"
8-
require_ci_to_pass: yes
8+
require_ci_to_pass: yes # yamllint disable-line rule:truthy
99
notify:
10-
wait_for_ci: yes
10+
wait_for_ci: yes # yamllint disable-line rule:truthy
1111

1212
coverage:
1313
precision: 2
@@ -16,24 +16,24 @@ coverage:
1616
status:
1717
project:
1818
default:
19-
base: auto # target to compare against
20-
target: auto # target "X%" coverage to hit on project
21-
threshold: 0.5% # allow this much decrease from base
19+
base: auto # target to compare against
20+
target: auto # target "X%" coverage to hit on project
21+
threshold: 0.5% # allow this much decrease from base
2222
if_ci_failed: error
2323
patch:
2424
default:
25-
base: auto # target to compare against
26-
target: 50% # target "X%" coverage to hit on patch
27-
# threshold: 50% # allow this much decrease on patch
25+
base: auto # target to compare against
26+
target: 50% # target "X%" coverage to hit on patch
27+
# threshold: 50% # allow this much decrease on patch
2828
changes: false
2929

3030
parsers:
3131
gcov:
3232
branch_detection:
33-
conditional: yes
34-
loop: yes
35-
method: no
36-
macro: no
33+
conditional: yes # yamllint disable-line rule:truthy
34+
loop: yes # yamllint disable-line rule:truthy
35+
method: no # yamllint disable-line rule:truthy
36+
macro: no # yamllint disable-line rule:truthy
3737

3838
# https://docs.codecov.io/docs/ignoring-paths
3939
# ignore:
@@ -43,4 +43,4 @@ parsers:
4343
comment:
4444
layout: header, diff, sunburst, uncovered
4545
behavior: default
46-
require_changes: true # if true: only post the comment if coverage changes
46+
require_changes: true # if true: only post the comment if coverage changes

0 commit comments

Comments
 (0)