From 2c946a943699030001f8b026ffcfa2755dcf84b7 Mon Sep 17 00:00:00 2001 From: kusch lionel Date: Wed, 25 Jun 2025 10:38:15 +0200 Subject: [PATCH] fix yml checking --- .github/workflows/testing.yml | 9 ++++----- .yamllint.yml | 2 -- codecov.yml | 26 +++++++++++++------------- 3 files changed, 17 insertions(+), 20 deletions(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index d60f38f5..00f84011 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -25,7 +25,7 @@ jobs: steps: # Install skada - - name: Checking Out Repository + - name: Checking Out Repository # yamllint disable-line rule:indentation uses: actions/checkout@v4 # Cache 'skada' datasets - name: Create/Restore Skada Data Cache @@ -46,7 +46,6 @@ jobs: pre-commit run --all-files - Test-minimal: runs-on: ubuntu-latest strategy: @@ -57,7 +56,7 @@ jobs: steps: # Install skada - - name: Checking Out Repository + - name: Checking Out Repository # yamllint disable-line rule:indentation uses: actions/checkout@v4 # Cache 'skada' datasets - name: Create/Restore Skada Data Cache @@ -98,7 +97,7 @@ jobs: steps: # Install skada - - name: Checking Out Repository + - name: Checking Out Repository # yamllint disable-line rule:indentation uses: actions/checkout@v4 # Cache 'skada' datasets - name: Create/Restore Skada Data Cache @@ -125,4 +124,4 @@ jobs: env: token: ${{ secrets.CODECOV_TOKEN }} verbose: true - fail_ci_if_error: true \ No newline at end of file + fail_ci_if_error: true diff --git a/.yamllint.yml b/.yamllint.yml index 69344d2e..d38e3704 100644 --- a/.yamllint.yml +++ b/.yamllint.yml @@ -1,9 +1,7 @@ extends: default ignore: | - .github/workflows/testing.yml .circleci/config.yml - codecov.yml rules: line-length: disable diff --git a/codecov.yml b/codecov.yml index ffef6ffa..2a0b4be2 100644 --- a/codecov.yml +++ b/codecov.yml @@ -5,9 +5,9 @@ codecov: bot: "codecov-io" strict_yaml_branch: "yaml-config" - require_ci_to_pass: yes + require_ci_to_pass: yes # yamllint disable-line rule:truthy notify: - wait_for_ci: yes + wait_for_ci: yes # yamllint disable-line rule:truthy coverage: precision: 2 @@ -16,24 +16,24 @@ coverage: status: project: default: - base: auto # target to compare against - target: auto # target "X%" coverage to hit on project - threshold: 0.5% # allow this much decrease from base + base: auto # target to compare against + target: auto # target "X%" coverage to hit on project + threshold: 0.5% # allow this much decrease from base if_ci_failed: error patch: default: - base: auto # target to compare against - target: 50% # target "X%" coverage to hit on patch - # threshold: 50% # allow this much decrease on patch + base: auto # target to compare against + target: 50% # target "X%" coverage to hit on patch + # threshold: 50% # allow this much decrease on patch changes: false parsers: gcov: branch_detection: - conditional: yes - loop: yes - method: no - macro: no + conditional: yes # yamllint disable-line rule:truthy + loop: yes # yamllint disable-line rule:truthy + method: no # yamllint disable-line rule:truthy + macro: no # yamllint disable-line rule:truthy # https://docs.codecov.io/docs/ignoring-paths # ignore: @@ -43,4 +43,4 @@ parsers: comment: layout: header, diff, sunburst, uncovered behavior: default - require_changes: true # if true: only post the comment if coverage changes + require_changes: true # if true: only post the comment if coverage changes