support for parameterized github api url#57
Merged
jcfr merged 1 commit intoApr 11, 2019
Conversation
Collaborator
|
Thanks for the contribution 👍 Would it be possible to have a look at the following error: I suggest to do this instead: global _github_api_url
_github_api_url = github_api_url |
furlongm
force-pushed
the
feature/parameterized-github-api-url
branch
2 times, most recently
from
b67ceaa to
1f714af
Compare
furlongm
force-pushed
the
feature/parameterized-github-api-url
branch
from
1f714af to
7d04474
Compare
Contributor
Author
|
Apologies, fixed that error. Travis checks seem to be failing now due to TOKEN not existing. Not sure if my change introduced that error? |
Collaborator
|
Thanks for updating the PR.
The failure are independent of your changes, the issue is that the |
Collaborator
|
As soon as the CI is done, I will release a new version of the package on PyPi. |
Collaborator
jcfr
added a commit
that referenced
this pull request
Mar 29, 2020
jcfr
added a commit
that referenced
this pull request
Mar 29, 2020
* fix-api-usage: Add github_api_url/set_github_api_url CHANGES: Reference changes introduced in pull-request #57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #55