Switch from setup.py to pyproject.toml#76
Merged
Conversation
This was referenced Feb 3, 2024
Collaborator
|
Thanks for the detailed report and contributions 🙏 |
Contributor
Author
|
Glad to help. Thank you for the quick merge! 😁 Echoing the request from December 2023, any chance a new release could be issued containing the fix from #73? |
Collaborator
Back in December @j0057 and I exchanged few emails and agreed on transferring the project to the I just followed with them about the transfer as well as shared maintenance of the corresponding PyPi project. As soon as this is completed, we will be moving forward with publishing a release. Thanks for your patience 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary Problem
The main problem is that #73 has been merged but has not yet been shipped as a packaged release to PyPI.
Secondary Problem
As a workaround, one might be tempted to install from current
masterin order to get the needed fix from #73:However, the above command yields a fatal error because the version number generated by the (deprecated)
setuptools-version-commandpackage required insetup.pydoes not conform to PEP 440:Unsuccessful Resolution in
setup.pyI spent entirely too much time trying to fix this in
setup.py, attempting to replace the deprecatedsetuptools-version-commandpackage withsetuptools-scm, but that just resulted insetup.pyyielding a version number of0.0.0every time.Solution: Replace
setup.pywithpyproject.tomlUltimately, by far the easiest solution to the Secondary Problem of not being able to install the current
masterbranch of this project was to switch fromsetup.pytopyproject.toml.No other changes are present in this pull request, in an effort to keep the scope as focused as possible.