Conversation
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
Pull Request validationFailed🔴 Failed or pending statuses:
Success🟢 Review - Reviewed by a member |
Contributor
Author
|
[test] |
Contributor
Author
|
[test] |
Testing Farm results
|
phracek
requested changes
Oct 20, 2025
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
All looks good.
But I would prefere also remove this file completelly including
the dir. It does not make sense to have it there https://github.com/sclorg/postgresql-container/blob/master/hooks/pre_build_distgen
phracek
approved these changes
Oct 20, 2025
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
Thanks for removing RHEL\7 and scl_enable
Member
|
[test] |
Contributor
Author
|
[test] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes mentions of and files for RHEL7. Also removes scl_enable and updates READMEs and scripts to not contain mentions of non-Stream CentOS, dead links, small typos, etc.