Conversation
Pull Request validationFailed🔴 Approval - missing or changes were requested Success🟢 CI - All checks have passed |
Testing Farm results
|
Contributor
Author
|
[test-all] |
phracek
requested changes
Nov 4, 2025
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
Thanks for this pull request. It removes a big dependence and our container will be more imputable from CVE.
The test RHEL10-OpenShift 4 is failing for this reason:
test/imagestreams/postgresql-rhel1.json. The change is easy.
See here: https://github.com/sclorg/mariadb-container/blob/master/test/test-lib-mysql.sh#L165. Just replace postgresql-${OS%[0-9]*}.json with postgresql-${OS//[0-9]/}.json in all test suite. Here https://github.com/sclorg/postgresql-container/blob/master/test/test-lib-postgresql.sh
Please address my changes. OS for RHEL9 has result postgresql-rhel.json but for RHEL10 is postgresql-rhel1.json.
Member
|
[test-all] |
phracek
approved these changes
Nov 5, 2025
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
Great. Thanks for removing bind-utils. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the bind-utils dependency and the usage of
digsince it was never being called in the tests