Bump toml versions#729
Merged
Merged
Conversation
masapr
approved these changes
Feb 26, 2024
Collaborator
masapr
left a comment
There was a problem hiding this comment.
I'm not sure, it's good practice to have different versions for different packages. Couldn't we put all packages to 0.17.0 ?
Contributor
Author
|
We could, but how can we track breaking changes for the different crates then? AFAIK it is not common in rust to have one version for all crates. |
Collaborator
|
I'm not saying we should have one version for all crates. I'm just saying, that at this point, we could set it to the same version number. Then, when we have minor changes, we can still have differences in the last digit behind the last dot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the following tomls:
related to #726