Skip to content

Commit 9c11837

Browse files
BrandonWengudpatil
authored andcommitted
Fix Bank Send Unit Tests (#348)
Fix Unit test
1 parent e1b1790 commit 9c11837

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

x/tokenfactory/keeper/admins_test.go

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,14 @@ func (suite *KeeperTestSuite) TestAdminMsgs() {
1717
queryRes, err := suite.queryClient.DenomAuthorityMetadata(suite.Ctx.Context(), &types.QueryDenomAuthorityMetadataRequest{
1818
Denom: suite.defaultDenom,
1919
})
20+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
2021
suite.Require().NoError(err)
2122
suite.Require().Equal(suite.TestAccs[0].String(), queryRes.AuthorityMetadata.Admin)
2223

2324
// Test minting to admins own account
2425
_, err = suite.msgServer.Mint(sdk.WrapSDKContext(suite.Ctx), types.NewMsgMint(suite.TestAccs[0].String(), sdk.NewInt64Coin(suite.defaultDenom, 10)))
26+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
27+
2528
addr0bal += 10
2629
suite.Require().NoError(err)
2730
suite.Require().True(suite.App.BankKeeper.GetBalance(suite.Ctx, suite.TestAccs[0], suite.defaultDenom).Amount.Int64() == addr0bal, suite.App.BankKeeper.GetBalance(suite.Ctx, suite.TestAccs[0], suite.defaultDenom))
@@ -34,12 +37,16 @@ func (suite *KeeperTestSuite) TestAdminMsgs() {
3437

3538
// Test burning from own account
3639
_, err = suite.msgServer.Burn(sdk.WrapSDKContext(suite.Ctx), types.NewMsgBurn(suite.TestAccs[0].String(), sdk.NewInt64Coin(suite.defaultDenom, 5)))
40+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
41+
3742
addr0bal -= 5
3843
suite.Require().NoError(err)
3944
suite.Require().True(suite.App.BankKeeper.GetBalance(suite.Ctx, suite.TestAccs[1], suite.defaultDenom).Amount.Int64() == addr1bal)
4045

4146
// Test Change Admin
4247
_, err = suite.msgServer.ChangeAdmin(sdk.WrapSDKContext(suite.Ctx), types.NewMsgChangeAdmin(suite.TestAccs[0].String(), suite.defaultDenom, suite.TestAccs[1].String()))
48+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
49+
4350
queryRes, err = suite.queryClient.DenomAuthorityMetadata(suite.Ctx.Context(), &types.QueryDenomAuthorityMetadataRequest{
4451
Denom: suite.defaultDenom,
4552
})
@@ -48,16 +55,22 @@ func (suite *KeeperTestSuite) TestAdminMsgs() {
4855

4956
// Make sure old admin can no longer do actions
5057
_, err = suite.msgServer.Burn(sdk.WrapSDKContext(suite.Ctx), types.NewMsgBurn(suite.TestAccs[0].String(), sdk.NewInt64Coin(suite.defaultDenom, 5)))
58+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
59+
5160
suite.Require().Error(err)
5261

5362
// Make sure the new admin works
5463
_, err = suite.msgServer.Mint(sdk.WrapSDKContext(suite.Ctx), types.NewMsgMint(suite.TestAccs[1].String(), sdk.NewInt64Coin(suite.defaultDenom, 5)))
64+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
65+
5566
addr1bal += 5
5667
suite.Require().NoError(err)
5768
suite.Require().True(suite.App.BankKeeper.GetBalance(suite.Ctx, suite.TestAccs[1], suite.defaultDenom).Amount.Int64() == addr1bal)
5869

5970
// Try setting admin to empty
6071
_, err = suite.msgServer.ChangeAdmin(sdk.WrapSDKContext(suite.Ctx), types.NewMsgChangeAdmin(suite.TestAccs[1].String(), suite.defaultDenom, ""))
72+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
73+
6174
suite.Require().NoError(err)
6275
queryRes, err = suite.queryClient.DenomAuthorityMetadata(suite.Ctx.Context(), &types.QueryDenomAuthorityMetadataRequest{
6376
Denom: suite.defaultDenom,
@@ -108,6 +121,8 @@ func (suite *KeeperTestSuite) TestMintDenom() {
108121
suite.Run(fmt.Sprintf("Case %s", tc.desc), func() {
109122
// Test minting to admins own account
110123
_, err := suite.msgServer.Mint(sdk.WrapSDKContext(suite.Ctx), types.NewMsgMint(tc.admin, sdk.NewInt64Coin(tc.mintDenom, 10)))
124+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
125+
111126
if tc.valid {
112127
addr0bal += 10
113128
suite.Require().NoError(err)
@@ -127,6 +142,8 @@ func (suite *KeeperTestSuite) TestBurnDenom() {
127142

128143
// mint 10 default token for testAcc[0]
129144
suite.msgServer.Mint(sdk.WrapSDKContext(suite.Ctx), types.NewMsgMint(suite.TestAccs[0].String(), sdk.NewInt64Coin(suite.defaultDenom, 10)))
145+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
146+
130147
addr0bal += 10
131148

132149
for _, tc := range []struct {
@@ -168,6 +185,8 @@ func (suite *KeeperTestSuite) TestBurnDenom() {
168185
suite.Run(fmt.Sprintf("Case %s", tc.desc), func() {
169186
// Test minting to admins own account
170187
_, err := suite.msgServer.Burn(sdk.WrapSDKContext(suite.Ctx), types.NewMsgBurn(tc.admin, sdk.NewInt64Coin(tc.burnDenom, 10)))
188+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
189+
171190
if tc.valid {
172191
addr0bal -= 10
173192
suite.Require().NoError(err)
@@ -228,14 +247,19 @@ func (suite *KeeperTestSuite) TestChangeAdminDenom() {
228247

229248
// Create a denom and mint
230249
res, err := suite.msgServer.CreateDenom(sdk.WrapSDKContext(suite.Ctx), types.NewMsgCreateDenom(suite.TestAccs[0].String(), "bitcoin"))
250+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
231251
suite.Require().NoError(err)
232252

233253
testDenom := res.GetNewTokenDenom()
234254

235255
_, err = suite.msgServer.Mint(sdk.WrapSDKContext(suite.Ctx), types.NewMsgMint(suite.TestAccs[0].String(), sdk.NewInt64Coin(testDenom, 10)))
256+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
257+
236258
suite.Require().NoError(err)
237259

238260
_, err = suite.msgServer.ChangeAdmin(sdk.WrapSDKContext(suite.Ctx), tc.msgChangeAdmin(testDenom))
261+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
262+
239263
if tc.expectedChangeAdminPass {
240264
suite.Require().NoError(err)
241265
} else {
@@ -258,6 +282,8 @@ func (suite *KeeperTestSuite) TestChangeAdminDenom() {
258282
// we test mint to test if admin authority is performed properly after admin change.
259283
if tc.msgMint != nil {
260284
_, err := suite.msgServer.Mint(sdk.WrapSDKContext(suite.Ctx), tc.msgMint(testDenom))
285+
suite.App.BankKeeper.WriteDeferredOperations(suite.Ctx)
286+
261287
if tc.expectedMintPass {
262288
suite.Require().NoError(err)
263289
} else {

0 commit comments

Comments
 (0)