feat(sidecar/assemble-genesis): apply spec.genesis.overrides to assembled genesis.json

[bdchatham]

Summary

SIP-3 testing needs a fresh test cluster whose staking.params.unbonding_time is 600s, not the cosmos default of 21 days. The controller already accepts SeiNodeDeployment.spec.genesis.overrides and propagates them through, but the sidecar was dropping them on the floor at the assemble-genesis step. This PR closes that gap.

Wire contract

AssembleGenesisRequest gains:

Overrides map[string]json.RawMessage `json:"overrides,omitempty"`

Keys are dotted snake_case paths into genesis.app_state. The first segment is the cosmos module name (a top-level key in app_state); subsequent segments walk into that module's JSON tree and replace the leaf verbatim. Values are raw JSON, so callers can override scalars, numbers, or whole objects:

key	value
staking.params.unbonding_time	"600s"
gov.params.max_deposit_period	"60s"
staking.params.max_validators	50
gov.params.voting_params	{"voting_period":"60s","quorum":"0.4"}

Validator-side flow change

GenesisAssembler.Handler() order is now:

downloadGentxFiles
  -> addMissingGenesisAccounts
  -> addExternalGenesisAccounts
  -> collectGentxs
  -> applyOverrides   <-- new
  -> uploadGenesis
  -> uploadPeers

Overrides are applied after collect-gentxs so any validator-derived state and persistent peers baked in by genutil.GenAppStateFromConfig are already in place — the override step is an in-place JSON patch on the final assembled genesis.json.

Design anchors (from the coral round)

• Single SND-level dispatch; no per-node fan-out for overrides.
• Bootstrap-only — the sidecar doesn't enforce immutability; the controller does that via CEL.
• Fails loudly on bad keys (empty, single-token, trailing/double dot, empty value, unknown module, non-object intermediates) so misconfiguration surfaces as a FailedTaskDetail on the owning SeiNodeDeployment rather than as a silently-ignored field.
• No cosmos-sdk module allowlist — the chain will fail loud on garbage at InitGenesis.

Other changes

• Drops the dead GenesisParams field from GenerateGentxRequest and its client-side mirror. The "reserved for future genesis customization" comment is now the dedicated Overrides path on the SND-level assemble task.
• New helper applyGenesisOverrides lives in sidecar/tasks/genesis_overrides.go; GenesisAssembler.applyOverrides is the disk-I/O glue that re-reads config/genesis.json, calls the helper, and writes back via genutil.ExportGenesisFile.

Companion change

The controller-side wiring (populating assembleParams.Overrides from SeiNodeDeployment.spec.genesis.overrides in internal/planner/group.go) is being implemented in parallel in sei-protocol/sei-k8s-controller. See sei-protocol/sei-k8s-controller#270.

Test plan

• go test ./sidecar/tasks/... -count=1 passes
• make test passes
• make lint clean
• Unit coverage in genesis_overrides_test.go: string/number/object leaves, deep nesting, cross-module, missing intermediate, idempotency, all error surfaces
• Disk-level coverage in assemble_genesis_test.go: applyOverrides mutates genesis.json and bubbles bad-key errors
• Wire round-trip test for AssembleGenesisRequest.Overrides
• Integration: SIP-3 test cluster boots with unbonding_time=600s and observes the resulting validator un-bonding behavior end-to-end

[cursor]

You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace.

To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard.