Skip to content

fix: fix config import breaking on windows#995

Merged
WikiRik merged 1 commit into
mainfrom
feature/ephys/fix-esm-windows
Jan 15, 2022
Merged

fix: fix config import breaking on windows#995
WikiRik merged 1 commit into
mainfrom
feature/ephys/fix-esm-windows

Conversation

@ephys
Copy link
Copy Markdown
Member

@ephys ephys commented Jan 15, 2022

Pull Request check-list

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions? Can't as we don't test on windows
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

#987 introduced a bug that caused sequelize-cli to be unusable on windows, as it tries to import the config file using import() instead of require(). Unlike require, import expects the path to be a valid URL.

Closes #994

@ephys ephys requested a review from WikiRik January 15, 2022 11:07
@ephys ephys self-assigned this Jan 15, 2022
@ephys ephys added the bug label Jan 15, 2022
@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Jan 15, 2022

Is there some way we can add a regression test for this?

@ephys
Copy link
Copy Markdown
Member Author

ephys commented Jan 15, 2022

I wish, but unless we start testing on windows, even trying to replicate a windows path will not work :/

image

@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Jan 15, 2022

Then we'll just have to accept this for now

@WikiRik WikiRik merged commit f19d811 into main Jan 15, 2022
@WikiRik WikiRik deleted the feature/ephys/fix-esm-windows branch January 15, 2022 11:28
WikiRik pushed a commit that referenced this pull request Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrading from v6.3.0 to v6.4.0 breaks sequelize-cli

2 participants