Skip to content

Adding target frameworks for net45 & netstandard2.0, removing netstandard1.3#105

Merged
merbla merged 1 commit intoserilog-contrib:devfrom
BrettJaner:dev
Apr 4, 2019
Merged

Adding target frameworks for net45 & netstandard2.0, removing netstandard1.3#105
merbla merged 1 commit intoserilog-contrib:devfrom
BrettJaner:dev

Conversation

@BrettJaner
Copy link
Copy Markdown
Contributor

@BrettJaner BrettJaner commented Mar 21, 2019

Related to issue #104. Trying to align target frameworks closer to how core Serilog library works. Here is what I think should be done. Let me know your thoughts.

  1. Removing targetframework for netstandard1.3 because it's just a superset of netstandard1.1
  2. Removing the need to target the full NETStandard.Library when targeting netstandard1.1 (NETStandard.Library ends up a dependency in the nupkg when targeting pre-netstandard2.0)
  3. Adding targetframework for net45 to use framework assembly for System.Net.Http when targeting full .NET Framework
  4. Adding targetframework for netstandard2.0 to remove need to reference System.Net.Http package

@merbla merbla merged commit 962cf8b into serilog-contrib:dev Apr 4, 2019
@merbla merbla mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants