Skip to content

Bugfix/udp tcp sink fixes #155#184

Merged
EEParker merged 4 commits intodevfrom
bugfix/udp-tcp-sink
Apr 9, 2024
Merged

Bugfix/udp tcp sink fixes #155#184
EEParker merged 4 commits intodevfrom
bugfix/udp-tcp-sink

Conversation

@EEParker
Copy link
Copy Markdown
Collaborator

@EEParker EEParker commented Apr 5, 2024

  • Embedd sources as Splunk.Logging.Common.Core is not signed upstream
  • netstandard2.1 is not supported by Splunk.Logging.Common.Core
  • Add a TCP socket unit test to ensure assembly can load

Fixes #155

@EEParker EEParker requested a review from VictorioBerra April 5, 2024 15:13
@EEParker
Copy link
Copy Markdown
Collaborator Author

EEParker commented Apr 5, 2024

Just a note, I'm not sure this is the correct solution, but I waned to put it out here for review and suggestions.

@EEParker EEParker force-pushed the bugfix/udp-tcp-sink branch from 3026053 to fafcf22 Compare April 9, 2024 14:08
@EEParker EEParker marked this pull request as ready for review April 9, 2024 14:08
@EEParker
Copy link
Copy Markdown
Collaborator Author

EEParker commented Apr 9, 2024

I reworked this and embedded the sources from the upstream unsigned library. This allows this assembly to be signed. @VictorioBerra

@EEParker
Copy link
Copy Markdown
Collaborator Author

EEParker commented Apr 9, 2024

Addresses #188

@EEParker EEParker merged commit e5482b3 into dev Apr 9, 2024
@EEParker EEParker added component-TCP component-UDP dependencies Pull requests that update a dependency file Semver-Patch Patch Update - non-breaking changes labels Apr 9, 2024
@EEParker EEParker self-assigned this Apr 9, 2024
@EEParker EEParker deleted the bugfix/udp-tcp-sink branch April 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-TCP component-UDP dependencies Pull requests that update a dependency file Semver-Patch Patch Update - non-breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Could not load file or assembly 'Splunk.Logging.Common', Version 1.0.0.0...."

1 participant