Skip to content

Commit 1203c1d

Browse files
committed
test: Reject all FF+Windows ClearKey testing (#8122)
My previous change, #8109, didn't go far enough. In a full test run, some ClearKey tests still crash Firefox in the lab. By removing it from the support dictionary used to gate DRM tests, we ensure all ClearKey tests are skipped.
1 parent d1ebe18 commit 1203c1d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/media/drm_engine.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1823,7 +1823,8 @@ shaka.media.DrmEngine = class {
18231823
if (goog.DEBUG && // not a production build
18241824
shaka.util.Platform.isWindows() && // on Windows
18251825
shaka.util.Platform.isFirefox()) { // with Firefox
1826-
// Do nothing, to avoid a crash in the FF ClearKey CDM.
1826+
// Reject this, since it crashes our tests.
1827+
throw new Error('Suppressing Firefox Windows ClearKey in testing!');
18271828
} else {
18281829
// Otherwise, create the CDM.
18291830
await access.createMediaKeys();

0 commit comments

Comments
 (0)