Skip to content

Commit 65cf077

Browse files
authored
feat(ads): Add getPodIndex to CS and SS ads (#5524)
Closes #5431
1 parent e2bf1de commit 65cf077

File tree

6 files changed

+53
-0
lines changed

6 files changed

+53
-0
lines changed

externs/ima.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,9 @@ google.ima.AdPodInfo = class {
204204

205205
/** @return {number} */
206206
getTimeOffset() {}
207+
208+
/** @return {number} */
209+
getPodIndex() {}
207210
};
208211

209212
/** @const */
@@ -447,6 +450,9 @@ google.ima.dai.api.AdPodInfo = class {
447450

448451
/** @return {number} */
449452
getTimeOffset() {}
453+
454+
/** @return {number} */
455+
getPodIndex() {}
450456
};
451457

452458

externs/shaka/ads.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,4 +286,9 @@ shaka.extern.IAd = class {
286286
* @return {number}
287287
*/
288288
getTimeOffset() {}
289+
290+
/**
291+
* @return {number}
292+
*/
293+
getPodIndex() {}
289294
};

lib/ads/client_side_ad.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,21 @@ shaka.ads.ClientSideAd = class {
323323
return podInfo.getTimeOffset();
324324
}
325325

326+
/**
327+
* @override
328+
* @export
329+
*/
330+
getPodIndex() {
331+
const podInfo = this.ad_.getAdPodInfo();
332+
if (podInfo == null) {
333+
// Defaults to 0 if this ad is not part of a pod, or the pod is not part
334+
// of an ad playlist.
335+
return 0;
336+
}
337+
338+
return podInfo.getPodIndex();
339+
}
340+
326341
/**
327342
* @override
328343
* @export

lib/ads/server_side_ad.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,21 @@ shaka.ads.ServerSideAd = class {
292292
return podInfo.getTimeOffset();
293293
}
294294

295+
/**
296+
* @override
297+
* @export
298+
*/
299+
getPodIndex() {
300+
const podInfo = this.ad_.getAdPodInfo();
301+
if (podInfo == null) {
302+
// Defaults to 0 if this ad is not part of a pod, or the pod is not part
303+
// of an ad playlist.
304+
return 0;
305+
}
306+
307+
return podInfo.getPodIndex();
308+
}
309+
295310
/**
296311
* @override
297312
* @export

lib/text/simple_text_displayer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ shaka.text.SimpleTextDisplayer = class {
5151
// kinds which can be displayed in the app's UI.
5252
this.textTrack_ = video.addTextTrack(
5353
'subtitles', shaka.Player.TextTrackLabel);
54+
console.log(this.textTrack_);
5455
}
5556
this.textTrack_.mode = 'hidden';
5657
}

test/test/util/fake_ad.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ shaka.test.FakeAd = class {
6464

6565
/** @private {number} */
6666
this.timeOffsetInPod_ = 1;
67+
68+
/** @private {number} */
69+
this.podIndex_ = 1;
6770
}
6871

6972
/**
@@ -300,6 +303,14 @@ shaka.test.FakeAd = class {
300303
return this.timeOffsetInPod_;
301304
}
302305

306+
/**
307+
* @override
308+
* @export
309+
*/
310+
getPodIndex() {
311+
return this.podIndex_;
312+
}
313+
303314
/**
304315
* @override
305316
* @export

0 commit comments

Comments
 (0)