Skip to content

Commit 92ecacb

Browse files
committed
Export default text parser plugins
This makes it easier for apps to app-specific build subclasses of these plugins. Closes #2428 Change-Id: I4fde7de76c139bfeddc1afecccf9374a49ecee19
1 parent 687319c commit 92ecacb

File tree

4 files changed

+33
-7
lines changed

4 files changed

+33
-7
lines changed

lib/text/mp4_ttml_parser.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ goog.require('shaka.util.Mp4Parser');
1313

1414
/**
1515
* @implements {shaka.extern.TextParser}
16+
* @export
1617
*/
1718
shaka.text.Mp4TtmlParser = class {
1819
constructor() {
@@ -23,7 +24,10 @@ shaka.text.Mp4TtmlParser = class {
2324
this.parser_ = new shaka.text.TtmlTextParser();
2425
}
2526

26-
/** @override **/
27+
/**
28+
* @override
29+
* @export
30+
*/
2731
parseInit(data) {
2832
const Mp4Parser = shaka.util.Mp4Parser;
2933

@@ -49,7 +53,10 @@ shaka.text.Mp4TtmlParser = class {
4953
}
5054
}
5155

52-
/** @override **/
56+
/**
57+
* @override
58+
* @export
59+
*/
5360
parseMedia(data, time) {
5461
const Mp4Parser = shaka.util.Mp4Parser;
5562

lib/text/mp4_vtt_parser.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ goog.require('shaka.util.TextParser');
2121

2222
/**
2323
* @implements {shaka.extern.TextParser}
24+
* @export
2425
*/
2526
shaka.text.Mp4VttParser = class {
2627
constructor() {
@@ -33,7 +34,10 @@ shaka.text.Mp4VttParser = class {
3334
this.timescale_ = null;
3435
}
3536

36-
/** @override */
37+
/**
38+
* @override
39+
* @export
40+
*/
3741
parseInit(data) {
3842
const Mp4Parser = shaka.util.Mp4Parser;
3943

@@ -86,7 +90,10 @@ shaka.text.Mp4VttParser = class {
8690
}
8791
}
8892

89-
/** @override */
93+
/**
94+
* @override
95+
* @export
96+
*/
9097
parseMedia(data, time) {
9198
if (!this.timescale_) {
9299
// Missing timescale for VTT content. We should have seen the init

lib/text/ttml_text_parser.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,21 @@ goog.require('shaka.util.XmlUtils');
1818

1919
/**
2020
* @implements {shaka.extern.TextParser}
21+
* @export
2122
*/
2223
shaka.text.TtmlTextParser = class {
23-
/** @override */
24+
/**
25+
* @override
26+
* @export
27+
*/
2428
parseInit(data) {
2529
goog.asserts.assert(false, 'TTML does not have init segments');
2630
}
2731

28-
/** @override */
32+
/**
33+
* @override
34+
* @export
35+
*/
2936
parseMedia(data, time) {
3037
const TtmlTextParser = shaka.text.TtmlTextParser;
3138
const XmlUtils = shaka.util.XmlUtils;

lib/text/vtt_text_parser.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,20 @@ goog.require('shaka.util.TextParser');
1717

1818
/**
1919
* @implements {shaka.extern.TextParser}
20+
* @export
2021
*/
2122
shaka.text.VttTextParser = class {
22-
/** @override */
23+
/**
24+
* @override
25+
* @export
26+
*/
2327
parseInit(data) {
2428
goog.asserts.assert(false, 'VTT does not have init segments');
2529
}
2630

2731
/**
2832
* @override
33+
* @export
2934
*/
3035
parseMedia(data, time) {
3136
const VttTextParser = shaka.text.VttTextParser;

0 commit comments

Comments
 (0)