Changes to fix compile errors when using the upstream Closure compiler.

Change-Id: I57b4ae73bdb1980938c3a740904e18da46c6ba23

Author: yohanncon

externs/mediakeys.js

@@ -167,7 +167,7 @@ MediaKeySession.prototype.keyStatuses;
 
 /**
  * @param {string} initDataType
- * @param {?BufferSource} initData
+ * @param {!BufferSource} initData
  * @return {!Promise}
  */
 MediaKeySession.prototype.generateRequest = function(initDataType, initData) {};

lib/media/eme_manager.js

@@ -498,8 +498,9 @@ shaka.media.EmeManager.prototype.onEncrypted_ = function(event) {
     this.allSessionsPresumedReady_.reject(exception);
     return;
   }
-
-  var p = session.generateRequest(event.initDataType, event.initData);
+  shaka.asserts.assert(event.initData);
+  var p = session.generateRequest(event.initDataType,
+      /** @type {!BufferSource} */(event.initData));
   this.requestGenerated_[initDataKey] = true;
 
   p.catch(shaka.util.TypedBind(this,
@@ -603,8 +604,8 @@ shaka.media.EmeManager.prototype.onKeyStatusChange_ = function(event) {
     if (message) {
       var error = new Error(message);
       error.type = v.value;
-      var event = shaka.util.FakeEvent.createErrorEvent(error);
-      this.dispatchEvent(event);
+      var errorEvent = shaka.util.FakeEvent.createErrorEvent(error);
+      this.dispatchEvent(errorEvent);
     }
   }
 };

lib/player/player.js

@@ -412,8 +412,8 @@ shaka.player.Player.prototype.onError_ = function(event) {
 
   var error = new Error(message);
   error.type = 'playback';
-  var event = shaka.util.FakeEvent.createErrorEvent(error);
-  this.dispatchEvent(event);
+  var errorEvent = shaka.util.FakeEvent.createErrorEvent(error);
+  this.dispatchEvent(errorEvent);
 };
 
 
@@ -977,13 +977,14 @@ shaka.player.Player.prototype.onWatchdogTimer_ = function() {
 
   if (this.video_.ended || this.video_.seeking) return;
 
-  var buffered = this.video_.buffered;
+  var bufferedProp = this.video_.buffered;
   // Counter-intuitively, the play head can advance audio-only while video is
   // buffering.  |buffered| will show the intersection of buffered ranges for
   // both audio and video, so this is an accurate way to sense that we are
   // buffering.  The 'stalled', 'waiting', and 'suspended' events do not work
   // for this purpose as of Chrome 38.  Nor will video.readyState.
-  var bufferEnd = buffered.length ? buffered.end(buffered.length - 1) : 0;
+  var bufferEnd =
+      bufferedProp.length ? bufferedProp.end(bufferedProp.length - 1) : 0;
   var buffered = bufferEnd - this.video_.currentTime;
   var threshold = shaka.player.Player.UNDERFLOW_THRESHOLD_;
   var fudgedBufferEnd = bufferEnd + shaka.player.Player.BUFFERED_FUDGE_FACTOR_;

lib/polyfill/patchedmediakeys_v01b.js

@@ -920,7 +920,7 @@ shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.getStatus =
 
 /**
  * Array entry 0 is the key, 1 is the value.
- * @return {Iterator.<Array.<BufferSource|string>>}
+ * @override
  */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.entries =
     function() {
@@ -977,7 +977,7 @@ shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.has =
 
 
 /**
- * @return {Iterator.<BufferSource>}
+ * @override
  */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.keys =
     function() {
@@ -993,7 +993,7 @@ shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.keys =
 
 
 /**
- * @return {Iterator.<string>}
+ * @override
  */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.values =
     function() {