Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: shaka-project/shaka-player
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.2.15
Choose a base ref
...
head repository: shaka-project/shaka-player
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.2.16
Choose a head ref
  • 20 commits
  • 54 files changed
  • 13 contributors

Commits on Dec 8, 2022

  1. fix: 4676 - Virgin Media set top box is incorrectly categorized as Ap…

    …ple/Safari (#4678)
    
    In order to get the playback working, I am excluding VirginMedia device
    from isApple() platform test, otherwise it incorrectly fails at
    isBrowserSupported().
    
    Fixes #4676
    
    Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
    2 people authored and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    65e9716 View commit details
    Browse the repository at this point in the history
  2. fix: WebVTT line not correctly positioned in UITextDisplayer (#4567) (#…

    …4682)
    
    As per spectification,
    [here](https://w3c.github.io/webvtt/#webvtt-line-cue-setting) and
    [there](https://w3c.github.io/webvtt/#webvtt-cue-line-alignment), my
    understanding is that a cue line with an optional alignment position
    `end`, e.g. `line:91%,end`, should have its bottom edge at 91% from the
    top of the screen.
    
    But the current code places it at 91% from the bottom of the screen.
    
    Fixes #4567
    
    Co-authored-by: Rodolphe Breton <rodolphe.breton@netgem.com>
    Co-authored-by: Joey Parrish <joeyparrish@google.com>
    3 people committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7c7be7c View commit details
    Browse the repository at this point in the history
  3. test: Fix platform detection for Xbox (#4685)

    Xbox One was being misdetected as Chrome, causing some mistakes in which
    tests are skipped.
    
    This does not appear to affect the library itself, since isChrome() and
    chromeVersion() are only used in tests currently.
    joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1ed2655 View commit details
    Browse the repository at this point in the history
  4. fix(ui): Check event cancelable before event.preventDefault (#4690)

    This error occurs when the first touch is initiated:
    
    [Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
    
    Added logic to confirm that the error can be cancelled before event.preventDefault.
    ocipap authored and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9864b88 View commit details
    Browse the repository at this point in the history
  5. test: Fix XML parser security tests on Xbox (#4695)

    Xbox seems to treat SVG and/or XML a little differently than other
    platforms, which led to a test failure on that platform. That went
    unnoticed because Xbox is offline in our lab. The issue was discovered
    while working to restore that platform in the lab test runs.
    joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6586e6d View commit details
    Browse the repository at this point in the history
  6. ci: Re-enable Tizen in the lab (#4698)

    An upgrade to Tizen Studio and the Docker image for it have solved our
    Tizen lab infra issues.
    joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f1c4d13 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    54f7a5c View commit details
    Browse the repository at this point in the history
  8. fix(HLS): Fix lowLatencyPresentationDelay when using autoLowLatencyMo…

    …de (#4712)
    
    Backported to v3.3.x
    avelad authored and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    984316d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a481596 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b56bd28 View commit details
    Browse the repository at this point in the history
  11. fix(cea): Fix MAX_ROWS in CEA-708 window (#4757)

    Fixes #3634
    avelad authored and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9dbcc05 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e198464 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    20900a9 View commit details
    Browse the repository at this point in the history
  14. docs: Update docs about dev dependencies (#4794)

    We require node v14+ and Java v11+ now.
    
    Closes #4721 
    Closes #4737
    joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5439a80 View commit details
    Browse the repository at this point in the history
  15. fix: Fix subtitles not added to DOM region (#4733)

    Reinstate previously removed region elements when next caption finds it
    is not there: Detect the absence and ensure `updateDOM` is true so its
    reinstated and the next caption can be shown.
    
    Closes #4680
    
    Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
    david-hm-morgan and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7f0e059 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    021d7bd View commit details
    Browse the repository at this point in the history
  17. fix(TTML): Add font-family mapping (#4801)

    Closes #4749
    avelad authored and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3827873 View commit details
    Browse the repository at this point in the history
  18. fix(cast): Use cast platform APIs in MediaCapabilties polyfill (#4727)

    See #4726 for more
    context.
    
    This allows Cast devices to properly filter stream variants with a
    resolution surpassing that of the device's capabilities.
    
    We place the fix in the `MediaCapabilities` polyfill since it's intended
    to be the right way to check for anything related to platform support.
    
    HDR support checks will require `eotf=smpte2048`, as indicated in
    #2813 (comment).
    Specifically, a `{hev|hvc}1.2` profile is only an *indication* of an HDR
    transfer function, but *may* be a non-HDR 10-bit color stream.
    
    In Cast, the platform can distinguish between the two by explicitly
    providing the transfer function; it uses `smpte2048` (`"PQ"`) because
    this is the "basis of HDR video formats..."
    (https://en.wikipedia.org/wiki/Perceptual_quantizer).
    JulianDomingo authored and joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    737dd27 View commit details
    Browse the repository at this point in the history
  19. test: Fix exceptions in tests (#4772)

    This fixes a test exception that did not fail its tests.  An HlsParser
    instance outlived the test run and failed after server disconnection.
    
    This issue was spotted while running the tests in a local browser in
    debug mode. It caused no test failures directly, but was an example of
    poor hygiene in our tests.
    joeyparrish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ade5c94 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. chore(v3.2.x): release 3.2.16 (#4805)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5590eed View commit details
    Browse the repository at this point in the history
Loading