Skip to content

fix(UI): Fix disable PiP when using documentPictureInPicture#5992

Merged
avelad merged 1 commit intoshaka-project:mainfrom
avelad:disable-pip
Dec 5, 2023
Merged

fix(UI): Fix disable PiP when using documentPictureInPicture#5992
avelad merged 1 commit intoshaka-project:mainfrom
avelad:disable-pip

Conversation

@avelad
Copy link
Member

@avelad avelad commented Dec 5, 2023

Fixes #5991

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release labels Dec 5, 2023
@avelad avelad added this to the v5.0 milestone Dec 5, 2023
@avelad avelad merged commit 6229284 into shaka-project:main Dec 5, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad deleted the disable-pip branch January 8, 2024 08:36
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to disable PictureInPicture in shaka player

3 participants