fix: Use infiniteLiveStreamDuration equal to true in Safari 17 or above#7901
Merged
avelad merged 2 commits intoshaka-project:mainfrom Jan 17, 2025
Merged
Conversation
avelad
added
type: bug
theodab
suggested changes
Jan 17, 2025
theodab
approved these changes
Jan 17, 2025
Collaborator
|
Incremental code coverage: 75.00% |
avelad
added a commit
that referenced
this pull request
Jan 17, 2025
avelad
added a commit
that referenced
this pull request
Jan 17, 2025
|
|
||
| const safariVersion = shaka.util.Platform.safariVersion(); | ||
| if (safariVersion && safariVersion >= 17) { | ||
| streaming.infiniteLiveStreamDuration = true; |
There was a problem hiding this comment.
For whatever reason, setting infiniteLiveStreamDuration to true seems to prevent goToLive from moving more than a few seconds at a time both on iOS and on my Mac, so not iOS-specific.
The seekRange().end that it tries to jump to appears to be the correct value. I can create a new issue for this if it's helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7899