fix: Check bandwidth when filtering streams#8125
Merged
avelad merged 2 commits intoshaka-project:mainfrom Feb 20, 2025
Merged
Conversation
Collaborator
|
Incremental code coverage: 100.00% |
Member
|
@vlazh could you add unit tests for this? |
avelad
added
type: bug
Contributor
Author
Yes, sure. |
Member
|
What is the point of this? If there is a better quality (in terms of resolution), why should we select this one? |
Contributor
Author
The point is we should not discard unique valid quality. Qualities are sorted by bandwidth but filtering by resolution. And if there is a situation showed in #8124, the valid unique quality will be discarded with no real reason. No other players (dash.js, hls.js, native hls) are filtering qualities in such way. |
avelad
approved these changes
Feb 20, 2025
joeyparrish
pushed a commit
that referenced
this pull request
Feb 22, 2025
joeyparrish
pushed a commit
that referenced
this pull request
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8124.