From 600aeb2449d7455a272973eb69a19998c3e366a2 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 28 Jan 2026 14:16:05 +0000 Subject: [PATCH] Add logging for unknown base types in profile generation Replaced `print` statement with `logger.warning` in `fit_tool/gen/profile.py` to properly log unknown base types. Also corrected the logged variable to `type_base_type_name` to provide useful information instead of `None`. Used standard `logging.getLogger(__name__)` pattern. Co-authored-by: shaonianche <16186646+shaonianche@users.noreply.github.com> --- fit_tool/gen/profile.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fit_tool/gen/profile.py b/fit_tool/gen/profile.py index 5508e09..24f7a71 100755 --- a/fit_tool/gen/profile.py +++ b/fit_tool/gen/profile.py @@ -1,3 +1,4 @@ +import logging import os.path from openpyxl import load_workbook @@ -6,6 +7,8 @@ from fit_tool.base_type import FieldType, BaseType from fit_tool.field import Field, ArrayType +logger = logging.getLogger(__name__) + class Message: @@ -138,9 +141,7 @@ def load(cls, filename): # it. type_base_type = BaseType.from_name(type_base_type_name) if not type_base_type: - # TODO: add proper logging - print( - 'Warning: Unknown base_type {}'.format(type_base_type)) + logger.warning('Unknown base_type: %s', type_base_type_name) continue current_type = FieldType(type_name, type_base_type) profile.add_type(current_type)