This repository was archived by the owner on May 13, 2025. It is now read-only.
Merged
Conversation
lyyder
force-pushed
the
banned-user-reviews
branch
from
f0b4112 to
ad77d5a
Compare
Show a dummy author display name in reviews from banned users.
lyyder
force-pushed
the
banned-user-reviews
branch
from
60d5047 to
06e869f
Compare
Gnito
reviewed
Jun 26, 2018
| } | ||
|
|
||
| .backgroundDark { | ||
| stop-color: var(--marketplaceColor); |
Contributor
There was a problem hiding this comment.
I'd add more variables to marketplace.css
--bannedColorLight: var(--marketplaceColorLight);stop-color: var(--bannedColorLight);
Gnito
suggested changes
Jun 26, 2018
Add new css properties for setting the background color used in the banned users icon.
lyyder
force-pushed
the
banned-user-reviews
branch
from
a8c38f3 to
33625ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently showing reviews from banned users breaks as the data provided for those users by the API is limited. This PR solves this problem by showing a placeholder name in place of the author display name in such cases. Also the background of the banned user avatar is changed to match the marketplace color theme.