Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Commit ff601dc

Browse files
authored
Merge pull request #1489 from sharetribe/update-font-size-textarea-select
Update font-size for textarea and select: otherwise mobile Safari zooms
2 parents 6b7516e + ad7be0b commit ff601dc

File tree

3 files changed

+19
-16
lines changed

3 files changed

+19
-16
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ way to update this template, but currently, we follow a pattern:
1414

1515
## Upcoming version 2021-XX-XX
1616

17+
- [fix] Mobile safari zooms if input-related elements have smaller font-size than 16px. This updates
18+
textarea and select element styles too. [#1489](https://github.com/sharetribe/ftw-daily/pull/1489)
1719
- [fix] Dependabot: Bump passport-oauth2 from 1.5.0 to 1.6.1
1820
[#1487](https://github.com/sharetribe/ftw-daily/pull/1487)
1921
- [fix] Fix bugs in checkout process:

src/styles/marketplaceDefaults.css

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -206,22 +206,6 @@ h6 {
206206
@apply --marketplaceH6FontStyles;
207207
}
208208

209-
input {
210-
font-family: var(--fontFamily);
211-
font-weight: var(--fontWeightMedium);
212-
font-size: 16px;
213-
line-height: 24px;
214-
letter-spacing: -0.1px;
215-
/* No margins for default font */
216-
217-
@media (--viewportMedium) {
218-
font-size: 16px;
219-
line-height: 32px;
220-
}
221-
}
222-
223-
textarea,
224-
select,
225209
li {
226210
@apply --marketplaceDefaultFontStyles;
227211
}
@@ -268,14 +252,17 @@ button {
268252

269253
select {
270254
@apply --marketplaceSelectStyles;
255+
@apply --marketplaceInputFontStyles;
271256
}
272257

273258
input {
274259
@apply --marketplaceInputStyles;
260+
@apply --marketplaceInputFontStyles;
275261
}
276262

277263
textarea {
278264
@apply --marketplaceInputStyles;
265+
@apply --marketplaceInputFontStyles;
279266

280267
/* Todo: All textareas are using auto-sizing extension which currently calculates required space incorrectly when box-sixing is "border-box" */
281268
box-sizing: content-box;

src/styles/propertySets.css

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,20 @@
528528
}
529529
}
530530

531+
--marketplaceInputFontStyles: {
532+
font-family: var(--fontFamily);
533+
font-weight: var(--fontWeightMedium);
534+
font-size: 16px;
535+
line-height: 24px;
536+
letter-spacing: -0.1px;
537+
/* No margins for default font */
538+
539+
@media (--viewportMedium) {
540+
font-size: 16px;
541+
line-height: 32px;
542+
}
543+
}
544+
531545
--marketplaceSelectStyles: {
532546
/* Dimensions */
533547
display: block;

0 commit comments

Comments
 (0)