Skip to content

Commit 3e22322

Browse files
authored
Merge pull request #177 from shiguredo/feature/fix-rpc-timeout
RPC タイムアウトの処理を修正する
2 parents 6a5b1d4 + 02b8d89 commit 3e22322

File tree

3 files changed

+70
-204
lines changed

3 files changed

+70
-204
lines changed

SoraUnitySdkExamples/.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,5 @@
5252
"temp/": true,
5353
"Temp/": true
5454
},
55-
"dotnet.defaultSolution": "SoraUnitySdkExamples.sln"
55+
"dotnet.defaultSolution": "SoraUnitySdkExamples.slnx"
5656
}

SoraUnitySdkExamples/Assets/SoraSample.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1206,15 +1206,12 @@ void HandleRpcResult(Sora.RpcResult result)
12061206
{
12071207
switch (result.ResultKind)
12081208
{
1209-
case Sora.RpcResultKind.ResponseReceived:
1209+
case Sora.RpcResultKind.Response:
12101210
Debug.LogFormat("RPC response: method={0}, response={1}", result.Method, result.ResponseJson);
12111211
break;
12121212
case Sora.RpcResultKind.Timeout:
12131213
Debug.LogErrorFormat("RPC timeout: method={0}", result.Method);
12141214
break;
1215-
case Sora.RpcResultKind.Canceled:
1216-
Debug.LogWarningFormat("RPC canceled: method={0}", result.Method);
1217-
break;
12181215
}
12191216
}
12201217

@@ -1227,7 +1224,7 @@ void RequestRpcWithInspectorSettings(string method, string paramsJson)
12271224

12281225
if (string.IsNullOrWhiteSpace(rpcTimeoutMillis))
12291226
{
1230-
sora.RequestRpc(method, paramsJson, HandleRpcResult);
1227+
sora.RequestRpc(method, paramsJson, HandleRpcResult, Sora.DefaultRpcTimeoutMillis);
12311228
return;
12321229
}
12331230

@@ -1237,11 +1234,6 @@ void RequestRpcWithInspectorSettings(string method, string paramsJson)
12371234
Debug.LogErrorFormat("RPC timeoutMillis の形式が不正です: timeoutMillis={0}", rpcTimeoutMillis);
12381235
return;
12391236
}
1240-
if (timeoutMillis <= 0)
1241-
{
1242-
Debug.LogErrorFormat("RPC timeoutMillis は 1 以上を指定してください: timeoutMillis={0}", timeoutMillis);
1243-
return;
1244-
}
12451237

12461238
sora.RequestRpc(method, paramsJson, HandleRpcResult, timeoutMillis);
12471239
}

0 commit comments

Comments
 (0)